Unified Diff: background.js
Issue 29674584:
Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: enabled testing via ?filterError=true
Created Jan. 25, 2018, 12:56 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
desktop-options.html » ('j')
|
desktop-options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: background.js |
| =================================================================== |
| --- a/background.js |
| +++ b/background.js |
| @@ -342,7 +342,7 @@ |
| parseFilters(text) |
| { |
| if (params.filterError) |
|
saroyanm
2018/01/29 11:44:48
Suggestion: copy pasting with the slight modificat
a.giammarchi
2018/01/29 17:36:32
not sure I understand this one. What do you mean?
saroyanm
2018/01/30 12:03:44
We will try to use part of filterValidation in ord
|
| - return {errors: ["Invalid filter"]}; |
| + return {errors: [{reason: "Invalid filter", lineno: 1}]}; |
| return { |
| filters: text.split("\n") |
| .filter((filter) => !!filter) |
« no previous file with comments
|
« no previous file
|
desktop-options.html » ('j')
|
desktop-options.html » ('J')
