desktop-options.html - Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: desktop-options.html

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)

Patch Set: enabled testing via ?filterError=true Created Jan. 25, 2018, 12:56 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: desktop-options.html

===================================================================

--- a/desktop-options.html

+++ b/desktop-options.html

@@ -289,6 +289,9 @@

+ <p>

+ <a class="i18n_options_customFilters_learn" id="link-filters-on-edit-error" target="_blank"></a>

saroyanm 2018/01/29 11:44:48 Detail: The current ID of this element is misslead

+ </p>

</header>

@@ -301,14 +304,18 @@

</p>

</div>

- <div class="side-controls">

- <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters">

- </button>

- <div class="side-controls" id="custom-filters-raw-controls">

- <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button>

- <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button>

+ <div id="custom-filters-edit-area">

+ <div id="custom-filters-edit-error" class="i18n_options_customFilters_edit_error"></div>

+ <div class="side-controls">

+ <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters">

+ </button>

+ <div id="custom-filters-raw-controls" class="side-controls">

+ <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button>

+ <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button>

+ </div>

</div>

+ <ul id="custom-filters-edit-filters"></ul>

saroyanm 2018/01/29 11:44:48 Detail/Suggestion: Why custom-filters-edit-filters

</div>

</section>

</div>