templates/minimal.tmpl - Issue 29676691: Issue 6237 - Implement wd navbar component in help.eyeo.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/minimal.tmpl

Issue 29676691: Issue 6237 - Implement wd navbar component in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Patch Set: Created Jan. 22, 2018, 10:39 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 This file is part of help.eyeo.com.	3 This file is part of help.eyeo.com.

4 Copyright (C) 2017-present eyeo GmbH	4 Copyright (C) 2017-present eyeo GmbH

5	5

6 help.eyeo.com is free software: you can redistribute it and/or modify	6 help.eyeo.com is free software: you can redistribute it and/or modify

7 it under the terms of the GNU General Public License as published by	7 it under the terms of the GNU General Public License as published by

8 the Free Software Foundation, either version 3 of the License, or	8 the Free Software Foundation, either version 3 of the License, or

9 (at your option) any later version.	9 (at your option) any later version.

10	10

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 {% endblock %}	52 {% endblock %}

53 </div>	53 </div>

54 {% block footer %}	54 {% block footer %}

55 {{ footer \| safe }}	55 {{ footer \| safe }}

56 {% endblock %}	56 {% endblock %}

57 <? include layout/footer ?>	57 <? include layout/footer ?>

58 {% block scripts %}	58 {% block scripts %}

59 {{ scripts \| safe }}	59 {{ scripts \| safe }}

60 {% endblock %}	60 {% endblock %}

61 <script src="/dist/js/main.min.js"></script>	61 <script src="/dist/js/main.min.js"></script>

	62 <script src="/js/navbar.js"></script><!-- website-defaults -->
	juliandoucette 2018/01/24 14:55:06 NIT: Weird... (comment) maybe we should: - Use a s NIT: Weird... (comment) maybe we should: - Use a subdirectory for page specific website-defaults includes e.g. /defaults/js/navbar.js - Import this script (navbar) into main.js ire 2018/01/25 10:15:05 This would require us to place the files within a Show quoted text On 2018/01/24 14:55:06, juliandoucette wrote: > NIT: Weird... (comment) maybe we should: > - Use a subdirectory for page specific website-defaults includes e.g. > /defaults/js/navbar.js This would require us to place the files within a `defaults` directory in the website-defaults repo I assume? Show quoted text > - Import this script (navbar) into main.js I think we can only do this by copy/paste (without introducing modules or something similar) and that would lose the advantage of using the exact same file from website-defaults. juliandoucette 2018/01/25 13:24:53 Yes; unfortunately (something to think about separ Show quoted text On 2018/01/25 10:15:05, ire wrote: > This would require us to place the files within a `defaults` directory in the > website-defaults repo I assume? Yes; unfortunately (something to think about separately). We discussed providing names for additional paths in settings.ini, but it wasn't a requirement for the MVP (of the additional-paths feature in the cms). We can re-consider this requirement in the future if we want. Show quoted text > I think we can only do this by copy/paste (without introducing modules or > something similar) and that would lose the advantage of using the exact same > file from website-defaults. Yes; unfortunately (this seems like a use case for modules, something to think about separately).
62 </body>	63 </body>

63 <html>	64 <html>

OLD	NEW

« no previous file with comments | « static/src/scss/layout/_navbar.scss ('k') | no next file » | no next file with comments »