Issue 6237 - Implement wd navbar component in help.eyeo.com

Issue 6237 - Implement wd navbar component in help.eyeo.com

[ire, 2018-01-22 10:40:25]

Ready for review

[juliandoucette, 2018-01-24 14:55:06]

LGTM + NIT

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.tmpl
File templates/minimal.tmpl (right):

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.t...
templates/minimal.tmpl:62: <script src="/js/navbar.js"></script><!--
website-defaults -->
NIT: Weird... (comment) maybe we should:
- Use a subdirectory for page specific website-defaults includes e.g.
/defaults/js/navbar.js
- Import this script (navbar) into main.js

[ire, 2018-01-25 10:15:06]

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.tmpl
File templates/minimal.tmpl (right):

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.t...
templates/minimal.tmpl:62: <script src="/js/navbar.js"></script><!--
website-defaults -->
On 2018/01/24 14:55:06, juliandoucette wrote:
> NIT: Weird... (comment) maybe we should:
> - Use a subdirectory for page specific website-defaults includes e.g.
> /defaults/js/navbar.js

This would require us to place the files within a `defaults` directory in the
website-defaults repo I assume? 

> - Import this script (navbar) into main.js

I think we can only do this by copy/paste (without introducing modules or
something similar) and that would lose the advantage of using the exact same
file from website-defaults.

[juliandoucette, 2018-01-25 13:24:53]

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.tmpl
File templates/minimal.tmpl (right):

https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.t...
templates/minimal.tmpl:62: <script src="/js/navbar.js"></script><!--
website-defaults -->
On 2018/01/25 10:15:05, ire wrote:
> This would require us to place the files within a `defaults` directory in the
> website-defaults repo I assume? 

Yes; unfortunately (something to think about separately).

We discussed providing names for additional paths in settings.ini, but it wasn't
a requirement for the MVP (of the additional-paths feature in the cms). We can
re-consider this requirement in the future if we want.

> I think we can only do this by copy/paste (without introducing modules or
> something similar) and that would lose the advantage of using the exact same
> file from website-defaults.

Yes; unfortunately (this seems like a use case for modules, something to think
about separately).

[ire, 2018-01-25 13:39:44]

On 2018/01/25 13:24:53, juliandoucette wrote:
>
https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.tmpl
> File templates/minimal.tmpl (right):
> 
>
https://codereview.adblockplus.org/29676691/diff/29676692/templates/minimal.t...
> templates/minimal.tmpl:62: <script src="/js/navbar.js"></script><!--
> website-defaults -->
> On 2018/01/25 10:15:05, ire wrote:
> > This would require us to place the files within a `defaults` directory in
the
> > website-defaults repo I assume? 
> 
> Yes; unfortunately (something to think about separately).
> 
> We discussed providing names for additional paths in settings.ini, but it
wasn't
> a requirement for the MVP (of the additional-paths feature in the cms). We can
> re-consider this requirement in the future if we want.
> 
> > I think we can only do this by copy/paste (without introducing modules or
> > something similar) and that would lose the advantage of using the exact same
> > file from website-defaults.
> 
> Yes; unfortunately (this seems like a use case for modules, something to think
> about separately).

Okay, I'll commit the change as it currently is until we come up with a better
way of handling this