Issue 29676711: Noissue - OwnedString::reset() and OwnedString::erase()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29676711: Noissue - OwnedString::reset() and OwnedString::erase() (Closed)

Created:
Jan. 22, 2018, 4:30 p.m. by hub

Modified:
Jan. 23, 2018, 3:10 p.m.

Reviewers:
sergei

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Noissue - OwnedString::reset() and OwnedString::erase()

Patch Set 1 #

Created: Jan. 22, 2018, 4:30 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	compiled/String.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

sergei

Jan. 23, 2018, 8:57 a.m. (2018-01-23 08:57:53 UTC) #2

LGTM, don't forget about review url and I would recommend to add "add " at the
beginning of the commit message
Noissue - add OwnedString::reset() and OwnedString::erase()

Review: https://codereview.adblockplus.org/29676711/

Expand All Messages | Collapse All Messages