Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29677586: Issue 6300 - Remove Maven and Ant support (Closed)

Created:
Jan. 23, 2018, 7:46 a.m. by anton
Modified:
Jan. 24, 2018, 1:20 p.m.
Reviewers:
diegocarloslima, jens
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6300 - Remove Maven and Ant support

Patch Set 1 #

Patch Set 2 : Removed versioning from AndroidManifest.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -999 lines) Patch
M .gitignore View 1 chunk +0 lines, -5 lines 0 comments Download
M .hgignore View 1 chunk +0 lines, -5 lines 0 comments Download
M README.md View 7 chunks +4 lines, -128 lines 0 comments Download
M libadblockplus-android-settings/AndroidManifest.xml View 1 1 chunk +1 line, -3 lines 0 comments Download
D libadblockplus-android-settings/build.xml View 1 chunk +0 lines, -85 lines 0 comments Download
D libadblockplus-android-settings/pom.xml View 1 chunk +0 lines, -69 lines 0 comments Download
D libadblockplus-android-settings/project.properties View 1 chunk +0 lines, -17 lines 0 comments Download
M libadblockplus-android-tests/AndroidManifest.xml View 1 1 chunk +1 line, -3 lines 0 comments Download
D libadblockplus-android-tests/build.xml View 1 chunk +0 lines, -116 lines 0 comments Download
D libadblockplus-android-tests/project.properties View 1 chunk +0 lines, -18 lines 0 comments Download
M libadblockplus-android-webview/AndroidManifest.xml View 1 1 chunk +1 line, -3 lines 0 comments Download
D libadblockplus-android-webview/build.xml View 1 chunk +0 lines, -85 lines 0 comments Download
D libadblockplus-android-webview/pom.xml View 1 chunk +0 lines, -69 lines 0 comments Download
D libadblockplus-android-webview/project.properties View 1 chunk +0 lines, -17 lines 0 comments Download
M libadblockplus-android-webviewapp/AndroidManifest.xml View 1 1 chunk +1 line, -3 lines 0 comments Download
D libadblockplus-android-webviewapp/build.xml View 1 chunk +0 lines, -76 lines 0 comments Download
D libadblockplus-android-webviewapp/pom.xml View 1 chunk +0 lines, -74 lines 0 comments Download
D libadblockplus-android-webviewapp/project.properties View 1 chunk +0 lines, -13 lines 0 comments Download
M libadblockplus-android/AndroidManifest.xml View 1 1 chunk +1 line, -3 lines 0 comments Download
D libadblockplus-android/build.xml View 1 chunk +0 lines, -77 lines 0 comments Download
D libadblockplus-android/pom.xml View 1 chunk +0 lines, -94 lines 0 comments Download
D libadblockplus-android/project.properties View 1 chunk +0 lines, -12 lines 0 comments Download
D pom.xml View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 11
anton
I have some concerns about pushing into Maven repo: https://issues.adblockplus.org/ticket/6300#comment:1 Patch set #1 does not ...
Jan. 23, 2018, 7:48 a.m. (2018-01-23 07:48:26 UTC) #1
anton
On 2018/01/23 07:48:26, anton wrote: > I have some concerns about pushing into Maven repo: ...
Jan. 23, 2018, 8:06 a.m. (2018-01-23 08:06:41 UTC) #2
jens
On 2018/01/23 08:06:41, anton wrote: > On 2018/01/23 07:48:26, anton wrote: > > I have ...
Jan. 23, 2018, 9:20 a.m. (2018-01-23 09:20:36 UTC) #3
jens
Jan. 23, 2018, 9:22 a.m. (2018-01-23 09:22:04 UTC) #4
anton
On 2018/01/23 09:20:36, jens wrote: > On 2018/01/23 08:06:41, anton wrote: > > On 2018/01/23 ...
Jan. 23, 2018, 9:23 a.m. (2018-01-23 09:23:26 UTC) #5
jens
On 2018/01/23 09:23:26, anton wrote: > On 2018/01/23 09:20:36, jens wrote: > > On 2018/01/23 ...
Jan. 23, 2018, 9:38 a.m. (2018-01-23 09:38:26 UTC) #6
diegocarloslima
On 2018/01/23 09:38:26, jens wrote: > On 2018/01/23 09:23:26, anton wrote: > > On 2018/01/23 ...
Jan. 23, 2018, 11:33 a.m. (2018-01-23 11:33:59 UTC) #7
anton
On 2018/01/23 11:33:59, diegocarloslima wrote: > On 2018/01/23 09:38:26, jens wrote: > > On 2018/01/23 ...
Jan. 23, 2018, 11:42 a.m. (2018-01-23 11:42:15 UTC) #8
anton
On 2018/01/23 11:42:15, anton wrote: > On 2018/01/23 11:33:59, diegocarloslima wrote: > > On 2018/01/23 ...
Jan. 24, 2018, 6:01 a.m. (2018-01-24 06:01:36 UTC) #9
anton
On 2018/01/24 06:01:36, anton wrote: > On 2018/01/23 11:42:15, anton wrote: > > On 2018/01/23 ...
Jan. 24, 2018, 6:01 a.m. (2018-01-24 06:01:47 UTC) #10
diegocarloslima
Jan. 24, 2018, 12:53 p.m. (2018-01-24 12:53:31 UTC) #11
On 2018/01/24 06:01:47, anton wrote:
> On 2018/01/24 06:01:36, anton wrote:
> > On 2018/01/23 11:42:15, anton wrote:
> > > On 2018/01/23 11:33:59, diegocarloslima wrote:
> > > > On 2018/01/23 09:38:26, jens wrote:
> > > > > On 2018/01/23 09:23:26, anton wrote:
> > > > > > On 2018/01/23 09:20:36, jens wrote:
> > > > > > > On 2018/01/23 08:06:41, anton wrote:
> > > > > > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > > > > > I have some concerns about pushing into Maven repo:
> > > > > > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > > > > > 
> > > > > > > > > Patch set #1 does not have pushing to Maven repo. To be
> discussed
> > > here
> > > > > > > > 
> > > > > > > > I think we should skip pushing to Maven repository for now as we
> > don't
> > > > > know
> > > > > > > the
> > > > > > > > most common use case.
> > > > > > > 
> > > > > > > Is it correct that all project.properties files are deleted and
not
> > > > > modified?
> > > > > > 
> > > > > > they should be deleted as they we created for Ant.
> > > > > 
> > > > > Okay, in this case LGTM
> > > > 
> > > > With this change, I think that we should also remove the versioning from
> > > > AndroidManifest.xml and just keep it in the build.gradle
> > > 
> > > Agree, to be done.
> > > Though at the moment it's overriden with values from `build.gradle` it's
not
> > > needed in `AndroidManifest.xml`.
> > 
> > See patch set #3
> 
> sorry, #2

LGTM

Powered by Google App Engine
This is Rietveld