Issue 6300 - Remove Maven and Ant support

Issue 6300 - Remove Maven and Ant support

[anton, 2018-01-23 07:48:26]

I have some concerns about pushing into Maven repo:
https://issues.adblockplus.org/ticket/6300#comment:1

Patch set #1 does not have pushing to Maven repo. To be discussed here

[anton, 2018-01-23 08:06:41]

On 2018/01/23 07:48:26, anton wrote:
> I have some concerns about pushing into Maven repo:
> https://issues.adblockplus.org/ticket/6300#comment:1
> 
> Patch set #1 does not have pushing to Maven repo. To be discussed here

I think we should skip pushing to Maven repository for now as we don't know the
most common use case.

[jens, 2018-01-23 09:20:36]

On 2018/01/23 08:06:41, anton wrote:
> On 2018/01/23 07:48:26, anton wrote:
> > I have some concerns about pushing into Maven repo:
> > https://issues.adblockplus.org/ticket/6300#comment:1
> > 
> > Patch set #1 does not have pushing to Maven repo. To be discussed here
> 
> I think we should skip pushing to Maven repository for now as we don't know
the
> most common use case.

Is it correct that all project.properties files are deleted and not modified?

[anton, 2018-01-23 09:23:26]

On 2018/01/23 09:20:36, jens wrote:
> On 2018/01/23 08:06:41, anton wrote:
> > On 2018/01/23 07:48:26, anton wrote:
> > > I have some concerns about pushing into Maven repo:
> > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > 
> > > Patch set #1 does not have pushing to Maven repo. To be discussed here
> > 
> > I think we should skip pushing to Maven repository for now as we don't know
> the
> > most common use case.
> 
> Is it correct that all project.properties files are deleted and not modified?

they should be deleted as they we created for Ant.

[jens, 2018-01-23 09:38:26]

On 2018/01/23 09:23:26, anton wrote:
> On 2018/01/23 09:20:36, jens wrote:
> > On 2018/01/23 08:06:41, anton wrote:
> > > On 2018/01/23 07:48:26, anton wrote:
> > > > I have some concerns about pushing into Maven repo:
> > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > 
> > > > Patch set #1 does not have pushing to Maven repo. To be discussed here
> > > 
> > > I think we should skip pushing to Maven repository for now as we don't
know
> > the
> > > most common use case.
> > 
> > Is it correct that all project.properties files are deleted and not
modified?
> 
> they should be deleted as they we created for Ant.

Okay, in this case LGTM

[diegocarloslima, 2018-01-23 11:33:59]

On 2018/01/23 09:38:26, jens wrote:
> On 2018/01/23 09:23:26, anton wrote:
> > On 2018/01/23 09:20:36, jens wrote:
> > > On 2018/01/23 08:06:41, anton wrote:
> > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > I have some concerns about pushing into Maven repo:
> > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > 
> > > > > Patch set #1 does not have pushing to Maven repo. To be discussed here
> > > > 
> > > > I think we should skip pushing to Maven repository for now as we don't
> know
> > > the
> > > > most common use case.
> > > 
> > > Is it correct that all project.properties files are deleted and not
> modified?
> > 
> > they should be deleted as they we created for Ant.
> 
> Okay, in this case LGTM

With this change, I think that we should also remove the versioning from
AndroidManifest.xml and just keep it in the build.gradle

[anton, 2018-01-23 11:42:15]

On 2018/01/23 11:33:59, diegocarloslima wrote:
> On 2018/01/23 09:38:26, jens wrote:
> > On 2018/01/23 09:23:26, anton wrote:
> > > On 2018/01/23 09:20:36, jens wrote:
> > > > On 2018/01/23 08:06:41, anton wrote:
> > > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > > I have some concerns about pushing into Maven repo:
> > > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > > 
> > > > > > Patch set #1 does not have pushing to Maven repo. To be discussed
here
> > > > > 
> > > > > I think we should skip pushing to Maven repository for now as we don't
> > know
> > > > the
> > > > > most common use case.
> > > > 
> > > > Is it correct that all project.properties files are deleted and not
> > modified?
> > > 
> > > they should be deleted as they we created for Ant.
> > 
> > Okay, in this case LGTM
> 
> With this change, I think that we should also remove the versioning from
> AndroidManifest.xml and just keep it in the build.gradle

Agree, to be done.
Though at the moment it's overriden with values from `build.gradle` it's not
needed in `AndroidManifest.xml`.

[anton, 2018-01-24 06:01:36]

On 2018/01/23 11:42:15, anton wrote:
> On 2018/01/23 11:33:59, diegocarloslima wrote:
> > On 2018/01/23 09:38:26, jens wrote:
> > > On 2018/01/23 09:23:26, anton wrote:
> > > > On 2018/01/23 09:20:36, jens wrote:
> > > > > On 2018/01/23 08:06:41, anton wrote:
> > > > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > > > I have some concerns about pushing into Maven repo:
> > > > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > > > 
> > > > > > > Patch set #1 does not have pushing to Maven repo. To be discussed
> here
> > > > > > 
> > > > > > I think we should skip pushing to Maven repository for now as we
don't
> > > know
> > > > > the
> > > > > > most common use case.
> > > > > 
> > > > > Is it correct that all project.properties files are deleted and not
> > > modified?
> > > > 
> > > > they should be deleted as they we created for Ant.
> > > 
> > > Okay, in this case LGTM
> > 
> > With this change, I think that we should also remove the versioning from
> > AndroidManifest.xml and just keep it in the build.gradle
> 
> Agree, to be done.
> Though at the moment it's overriden with values from `build.gradle` it's not
> needed in `AndroidManifest.xml`.

See patch set #3

[anton, 2018-01-24 06:01:47]

On 2018/01/24 06:01:36, anton wrote:
> On 2018/01/23 11:42:15, anton wrote:
> > On 2018/01/23 11:33:59, diegocarloslima wrote:
> > > On 2018/01/23 09:38:26, jens wrote:
> > > > On 2018/01/23 09:23:26, anton wrote:
> > > > > On 2018/01/23 09:20:36, jens wrote:
> > > > > > On 2018/01/23 08:06:41, anton wrote:
> > > > > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > > > > I have some concerns about pushing into Maven repo:
> > > > > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > > > > 
> > > > > > > > Patch set #1 does not have pushing to Maven repo. To be
discussed
> > here
> > > > > > > 
> > > > > > > I think we should skip pushing to Maven repository for now as we
> don't
> > > > know
> > > > > > the
> > > > > > > most common use case.
> > > > > > 
> > > > > > Is it correct that all project.properties files are deleted and not
> > > > modified?
> > > > > 
> > > > > they should be deleted as they we created for Ant.
> > > > 
> > > > Okay, in this case LGTM
> > > 
> > > With this change, I think that we should also remove the versioning from
> > > AndroidManifest.xml and just keep it in the build.gradle
> > 
> > Agree, to be done.
> > Though at the moment it's overriden with values from `build.gradle` it's not
> > needed in `AndroidManifest.xml`.
> 
> See patch set #3

sorry, #2

[diegocarloslima, 2018-01-24 12:53:31]

On 2018/01/24 06:01:47, anton wrote:
> On 2018/01/24 06:01:36, anton wrote:
> > On 2018/01/23 11:42:15, anton wrote:
> > > On 2018/01/23 11:33:59, diegocarloslima wrote:
> > > > On 2018/01/23 09:38:26, jens wrote:
> > > > > On 2018/01/23 09:23:26, anton wrote:
> > > > > > On 2018/01/23 09:20:36, jens wrote:
> > > > > > > On 2018/01/23 08:06:41, anton wrote:
> > > > > > > > On 2018/01/23 07:48:26, anton wrote:
> > > > > > > > > I have some concerns about pushing into Maven repo:
> > > > > > > > > https://issues.adblockplus.org/ticket/6300#comment:1
> > > > > > > > > 
> > > > > > > > > Patch set #1 does not have pushing to Maven repo. To be
> discussed
> > > here
> > > > > > > > 
> > > > > > > > I think we should skip pushing to Maven repository for now as we
> > don't
> > > > > know
> > > > > > > the
> > > > > > > > most common use case.
> > > > > > > 
> > > > > > > Is it correct that all project.properties files are deleted and
not
> > > > > modified?
> > > > > > 
> > > > > > they should be deleted as they we created for Ant.
> > > > > 
> > > > > Okay, in this case LGTM
> > > > 
> > > > With this change, I think that we should also remove the versioning from
> > > > AndroidManifest.xml and just keep it in the build.gradle
> > > 
> > > Agree, to be done.
> > > Though at the moment it's overriden with values from `build.gradle` it's
not
> > > needed in `AndroidManifest.xml`.
> > 
> > See patch set #3
> 
> sorry, #2

LGTM