Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 29678581: Issue 6000 - Rename "libadblockplus-android" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by anton
Modified:
5 days, 1 hour ago
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 6000 - Rename "libadblockplus-android" New code review https://codereview.adblockplus.org/29782630/

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-126 lines, -33717 lines) Patch
README.md View 10 chunks +18 lines, -18 lines 0 comments Download
adblock-android-settings/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/build.gradle View 3 chunks +5 lines, -5 lines 0 comments Download
adblock-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_remove.png View Binary file 0 comments Download
adblock-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xxxhdpi/ic_add_circle_outline_black_24dp.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/drawable-xxxhdpi/ic_remove_circle_outline_black_24dp.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-ar/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-de/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-el/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-es-rUS/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-es/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-fa/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-fr/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-hi/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-hu/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-in/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-it/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-ja/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-ko/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-pl/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-pt-rBR/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-pt/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-ro/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-ru/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-th/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-tr/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-uk/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-vi/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-zh-rCN/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values-zh-rTW/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values/adblock_settings_dimen_internal.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values/adblock_settings_strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/res/values/adblock_settings_strings_internal.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android-settings/res/xml/preference_adblock_general.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettingsStorage.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/BaseSettingsFragment.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/GeneralSettingsFragment.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-settings/src/org/adblockplus/libadblockplus/android/settings/WhitelistedDomainsSettingsFragment.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/build.gradle View 3 chunks +5 lines, -5 lines 0 comments Download
adblock-android-tests/libs/android-testing-support.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/libs/junit-4.11.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/proguard-project.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/res/raw/easylist.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/res/raw/exceptionrules.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/LazyLogSystem.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/MockLogSystem.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/MockUpdateAvailableCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/MockWebRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/NoOpUpdaterCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/ThrowingLogSystem.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BasePlatformTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/ConsoleJsObjectTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineUpdaterTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackImplTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/JsTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/assets/css.js View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/assets/empty.js View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/assets/hide.js View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/assets/inject.js View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webview/build.gradle View 3 chunks +5 lines, -5 lines 0 comments Download
adblock-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/build.gradle View 3 chunks +5 lines, -5 lines 0 comments Download
adblock-android-webviewapp/res/drawable/icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/res/layout/activity_main.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/res/raw/easylist.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/res/raw/exceptionrules.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/MainActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/SettingsActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android/build.gradle View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/Android.mk View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/Application.mk View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniCallbacks.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniCallbacks.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniEventCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniFilter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniFilter.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniFilterChangeCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniFilterEngine.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android/jni/JniIsAllowedConnectionTypeCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniJsEngine.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniJsValue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniJsValue.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniLibrary.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android/jni/JniLogSystem.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniLogSystem.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniNotification.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniNotification.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniPlatform.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniPlatform.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniShowNotificationCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniSubscription.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniUpdateAvailableCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniUpdateCheckDoneCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniWebRequest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/JniWebRequest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/jni/Utils.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/AdblockPlusException.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/AppInfo.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Disposable.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Disposer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/EventCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Filter.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/FilterChangeCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/FilterEngine.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/HeaderEntry.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/JniExceptionHandler.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/JsEngine.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/JsValue.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/LogSystem.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Notification.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Platform.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/ServerResponse.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/ShowNotificationCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/Subscription.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/UpdateAvailableCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/UpdateCheckDoneCallback.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/WebRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + adblock-android/src/org/adblockplus/libadblockplus/android/AdblockEngineProvider.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidLogSystem.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/ConnectionType.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/IsAllowedConnectionCallbackImpl.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/Subscription.java View 0 chunks +-1 lines, --1 lines 0 comments Download
adblock-android/src/org/adblockplus/libadblockplus/android/Utils.java View 0 chunks +-1 lines, --1 lines 0 comments Download
build.gradle View 1 chunk +1 line, -1 line 0 comments Download
dependencies View 1 chunk +1 line, -1 line 0 comments Download
libadblockplus-android-settings/AndroidManifest.xml View 1 chunk +0 lines, -12 lines 0 comments Download
libadblockplus-android-settings/build.gradle View 1 chunk +0 lines, -35 lines 0 comments Download
libadblockplus-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_remove.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_add.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D libadblockplus-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_remove.png View Binary file 0 comments Download
libadblockplus-android-settings/res/drawable-xxxhdpi/ic_add_circle_outline_black_24dp.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/drawable-xxxhdpi/ic_remove_circle_outline_black_24dp.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml View 1 chunk +0 lines, -30 lines 0 comments Download
D libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml View 1 chunk +0 lines, -52 lines 0 comments Download
libadblockplus-android-settings/res/values-ar/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-de/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-el/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-es-rUS/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-es/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-fa/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D libadblockplus-android-settings/res/values-hi/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-hu/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-in/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-it/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-ja/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-ko/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-pl/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-pt-rBR/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D libadblockplus-android-settings/res/values-pt/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-ro/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-th/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-tr/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-uk/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-vi/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-zh-rCN/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values-zh-rTW/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values/adblock_settings_dimen_internal.xml View 1 chunk +0 lines, -7 lines 0 comments Download
libadblockplus-android-settings/res/values/adblock_settings_strings.xml View 1 chunk +0 lines, -18 lines 0 comments Download
libadblockplus-android-settings/res/values/adblock_settings_strings_internal.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D libadblockplus-android-settings/res/xml/preference_adblock_general.xml View 1 chunk +0 lines, -33 lines 0 comments Download
D libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java View 1 chunk +0 lines, -209 lines 0 comments Download
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java View 1 chunk +0 lines, -98 lines 0 comments Download
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettingsStorage.java View 1 chunk +0 lines, -81 lines 0 comments Download
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/BaseSettingsFragment.java View 1 chunk +0 lines, -122 lines 0 comments Download
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/GeneralSettingsFragment.java View 1 chunk +0 lines, -330 lines 0 comments Download
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java View 1 chunk +0 lines, -217 lines 0 comments Download
D libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/WhitelistedDomainsSettingsFragment.java View 1 chunk +0 lines, -249 lines 0 comments Download
libadblockplus-android-tests/AndroidManifest.xml View 1 chunk +0 lines, -36 lines 0 comments Download
libadblockplus-android-tests/build.gradle View 1 chunk +0 lines, -54 lines 0 comments Download
libadblockplus-android-tests/libs/android-testing-support.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-tests/libs/junit-4.11.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-tests/proguard-project.txt View 1 chunk +0 lines, -20 lines 0 comments Download
libadblockplus-android-tests/res/raw/easylist.txt View 1 chunk +0 lines, -6138 lines 0 comments Download
libadblockplus-android-tests/res/raw/exceptionrules.txt View 1 chunk +0 lines, -3725 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyLogSystem.java View 1 chunk +0 lines, -26 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java View 1 chunk +0 lines, -32 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java View 1 chunk +0 lines, -39 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockLogSystem.java View 1 chunk +0 lines, -50 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockUpdateAvailableCallback.java View 1 chunk +0 lines, -39 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockWebRequest.java View 1 chunk +0 lines, -30 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/NoOpUpdaterCallback.java View 1 chunk +0 lines, -26 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingLogSystem.java View 1 chunk +0 lines, -27 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java View 1 chunk +0 lines, -29 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java View 1 chunk +0 lines, -337 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 1 chunk +0 lines, -140 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java View 1 chunk +0 lines, -65 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java View 1 chunk +0 lines, -56 lines 0 comments Download
D libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java View 1 chunk +0 lines, -32 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BasePlatformTest.java View 1 chunk +0 lines, -69 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/ConsoleJsObjectTest.java View 1 chunk +0 lines, -99 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 1 chunk +0 lines, -487 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineUpdaterTest.java View 1 chunk +0 lines, -53 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java View 1 chunk +0 lines, -77 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackImplTest.java View 1 chunk +0 lines, -186 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java View 1 chunk +0 lines, -163 lines 0 comments Download
D libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java View 1 chunk +0 lines, -133 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsTest.java View 1 chunk +0 lines, -265 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 1 chunk +0 lines, -148 lines 0 comments Download
D libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java View 1 chunk +0 lines, -125 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java View 1 chunk +0 lines, -265 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 1 chunk +0 lines, -42 lines 0 comments Download
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java View 1 chunk +0 lines, -128 lines 0 comments Download
libadblockplus-android-webview/AndroidManifest.xml View 1 chunk +0 lines, -9 lines 0 comments Download
libadblockplus-android-webview/assets/css.js View 1 chunk +0 lines, -21 lines 0 comments Download
libadblockplus-android-webview/assets/empty.js View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-webview/assets/hide.js View 1 chunk +0 lines, -28 lines 0 comments Download
libadblockplus-android-webview/assets/inject.js View 1 chunk +0 lines, -44 lines 0 comments Download
D libadblockplus-android-webview/build.gradle View 1 chunk +0 lines, -34 lines 0 comments Download
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java View 1 chunk +0 lines, -1441 lines 0 comments Download
libadblockplus-android-webviewapp/AndroidManifest.xml View 1 chunk +0 lines, -38 lines 0 comments Download
libadblockplus-android-webviewapp/build.gradle View 1 chunk +0 lines, -47 lines 0 comments Download
libadblockplus-android-webviewapp/res/drawable/icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
libadblockplus-android-webviewapp/res/layout/activity_main.xml View 1 chunk +0 lines, -61 lines 0 comments Download
libadblockplus-android-webviewapp/res/raw/easylist.txt View 1 chunk +0 lines, -6138 lines 0 comments Download
libadblockplus-android-webviewapp/res/raw/exceptionrules.txt View 1 chunk +0 lines, -3725 lines 0 comments Download
D libadblockplus-android-webviewapp/res/values/strings.xml View 1 chunk +0 lines, -12 lines 0 comments Download
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java View 1 chunk +0 lines, -50 lines 0 comments Download
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/MainActivity.java View 1 chunk +0 lines, -256 lines 0 comments Download
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/SettingsActivity.java View 1 chunk +0 lines, -119 lines 0 comments Download
libadblockplus-android/AndroidManifest.xml View 1 chunk +0 lines, -9 lines 0 comments Download
libadblockplus-android/build.gradle View 1 chunk +0 lines, -79 lines 0 comments Download
libadblockplus-android/jni/Android.mk View 1 chunk +0 lines, -123 lines 0 comments Download
libadblockplus-android/jni/Application.mk View 1 chunk +0 lines, -5 lines 0 comments Download
libadblockplus-android/jni/JniCallbacks.h View 1 chunk +0 lines, -111 lines 0 comments Download
libadblockplus-android/jni/JniCallbacks.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D libadblockplus-android/jni/JniEventCallback.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
libadblockplus-android/jni/JniFilter.h View 1 chunk +0 lines, -27 lines 0 comments Download
libadblockplus-android/jni/JniFilter.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
libadblockplus-android/jni/JniFilterChangeCallback.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
libadblockplus-android/jni/JniFilterEngine.cpp View 1 chunk +0 lines, -548 lines 0 comments Download
D libadblockplus-android/jni/JniIsAllowedConnectionTypeCallback.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
libadblockplus-android/jni/JniJsEngine.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
libadblockplus-android/jni/JniJsValue.h View 1 chunk +0 lines, -38 lines 0 comments Download
libadblockplus-android/jni/JniJsValue.cpp View 1 chunk +0 lines, -229 lines 0 comments Download
libadblockplus-android/jni/JniLibrary.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
libadblockplus-android/jni/JniLogSystem.h View 1 chunk +0 lines, -27 lines 0 comments Download
libadblockplus-android/jni/JniLogSystem.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
libadblockplus-android/jni/JniNotification.h View 1 chunk +0 lines, -27 lines 0 comments Download
libadblockplus-android/jni/JniNotification.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
libadblockplus-android/jni/JniPlatform.h View 1 chunk +0 lines, -29 lines 0 comments Download
libadblockplus-android/jni/JniPlatform.cpp View 1 chunk +0 lines, -150 lines 0 comments Download
libadblockplus-android/jni/JniShowNotificationCallback.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
libadblockplus-android/jni/JniSubscription.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
libadblockplus-android/jni/JniUpdateAvailableCallback.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
libadblockplus-android/jni/JniUpdateCheckDoneCallback.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
libadblockplus-android/jni/JniWebRequest.h View 1 chunk +0 lines, -27 lines 0 comments Download
libadblockplus-android/jni/JniWebRequest.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
libadblockplus-android/jni/Utils.h View 1 chunk +0 lines, -219 lines 0 comments Download
libadblockplus-android/jni/Utils.cpp View 1 chunk +0 lines, -193 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/AdblockPlusException.java View 1 chunk +0 lines, -38 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/AppInfo.java View 1 chunk +0 lines, -101 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Disposable.java View 1 chunk +0 lines, -23 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Disposer.java View 1 chunk +0 lines, -94 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/EventCallback.java View 1 chunk +0 lines, -68 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Filter.java View 1 chunk +0 lines, -87 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/FilterChangeCallback.java View 1 chunk +0 lines, -66 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java View 1 chunk +0 lines, -266 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/HeaderEntry.java View 1 chunk +0 lines, -68 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java View 1 chunk +0 lines, -23 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/JniExceptionHandler.java View 1 chunk +0 lines, -75 lines 0 comments Download
D libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java View 1 chunk +0 lines, -104 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/JsValue.java View 1 chunk +0 lines, -161 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/LogSystem.java View 1 chunk +0 lines, -28 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Notification.java View 1 chunk +0 lines, -77 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java View 1 chunk +0 lines, -113 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/ServerResponse.java View 1 chunk +0 lines, -132 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/ShowNotificationCallback.java View 1 chunk +0 lines, -66 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/Subscription.java View 1 chunk +0 lines, -109 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/UpdateAvailableCallback.java View 1 chunk +0 lines, -66 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/UpdateCheckDoneCallback.java View 1 chunk +0 lines, -66 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/WebRequest.java View 1 chunk +0 lines, -25 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 1 chunk +0 lines, -644 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngineProvider.java View 1 chunk +0 lines, -54 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidLogSystem.java View 1 chunk +0 lines, -48 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java View 1 chunk +0 lines, -213 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java View 1 chunk +0 lines, -249 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/ConnectionType.java View 1 chunk +0 lines, -89 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/IsAllowedConnectionCallbackImpl.java View 1 chunk +0 lines, -71 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java View 1 chunk +0 lines, -255 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java View 1 chunk +0 lines, -30 lines 0 comments Download
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java View 1 chunk +0 lines, -111 lines 0 comments Download
settings.gradle View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9
anton
You can see lots of changes, but actually they are just: 1) renamed "libadblockplus-..." dirs ...
3 months, 3 weeks ago (2018-01-24 07:08:36 UTC) #1
jens
https://codereview.adblockplus.org/29678581/diff/29678582/adblockplus-android-webviewapp/build.gradle File adblockplus-android-webviewapp/build.gradle (left): https://codereview.adblockplus.org/29678581/diff/29678582/adblockplus-android-webviewapp/build.gradle#oldcode24 adblockplus-android-webviewapp/build.gradle:24: versionName "2.1" Why are we jumping from 5 to ...
3 months, 3 weeks ago (2018-01-24 10:53:04 UTC) #2
anton
On 2018/01/24 10:53:04, jens wrote: > https://codereview.adblockplus.org/29678581/diff/29678582/adblockplus-android-webviewapp/build.gradle > File adblockplus-android-webviewapp/build.gradle (left): > > https://codereview.adblockplus.org/29678581/diff/29678582/adblockplus-android-webviewapp/build.gradle#oldcode24 > ...
3 months, 3 weeks ago (2018-01-24 11:43:46 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29678581/diff/29678589/README.md File README.md (right): https://codereview.adblockplus.org/29678581/diff/29678589/README.md#newcode4 README.md:4: An Android library project, tests and demo application for ...
3 months, 3 weeks ago (2018-01-24 13:34:16 UTC) #4
anton
On 2018/01/24 13:34:16, diegocarloslima wrote: > https://codereview.adblockplus.org/29678581/diff/29678589/README.md > File README.md (right): > > https://codereview.adblockplus.org/29678581/diff/29678589/README.md#newcode4 > ...
3 months, 3 weeks ago (2018-01-24 13:43:12 UTC) #5
anton
On 2018/01/24 13:43:12, anton wrote: > On 2018/01/24 13:34:16, diegocarloslima wrote: > > https://codereview.adblockplus.org/29678581/diff/29678589/README.md > ...
3 months, 3 weeks ago (2018-01-29 11:12:04 UTC) #6
diegocarloslima
On 2018/01/29 11:12:04, anton wrote: > On 2018/01/24 13:43:12, anton wrote: > > On 2018/01/24 ...
3 months, 3 weeks ago (2018-01-29 15:12:14 UTC) #7
jens
On 2018/01/29 15:12:14, diegocarloslima wrote: > On 2018/01/29 11:12:04, anton wrote: > > On 2018/01/24 ...
3 months, 1 week ago (2018-02-08 07:46:30 UTC) #8
René Jeschke
5 days, 22 hours ago (2018-05-15 08:35:25 UTC) #9
On 2018/02/08 07:46:30, jens wrote:
> On 2018/01/29 15:12:14, diegocarloslima wrote:
> > On 2018/01/29 11:12:04, anton wrote:
> > > On 2018/01/24 13:43:12, anton wrote:
> > > > On 2018/01/24 13:34:16, diegocarloslima wrote:
> > > > > https://codereview.adblockplus.org/29678581/diff/29678589/README.md
> > > > > File README.md (right):
> > > > > 
> > > > >
> > https://codereview.adblockplus.org/29678581/diff/29678589/README.md#newcode4
> > > > > README.md:4: An Android library project, tests and demo application
for
> > > > > AdblockWebView widget.
> > > > > I think the word 'view' here is quite redundant since it's already
> present
> > > in
> > > > > AdblockWebView
> > > > > 
> > > > >
> > >
> https://codereview.adblockplus.org/29678581/diff/29678589/README.md#newcode16
> > > > > README.md:16: 
> > > > > In the README, we are calling our project Adblock Android SDK. For me,
> it
> > > > would
> > > > > be more consistent if we either:
> > > > > 1) Keep it Adblock Android SDK and rename the modules to
adblock-android
> > > > > 2) Change to Adblock Plus Android SDK and keep the modules as
> > > > > adblockplus-android
> > > > 
> > > > > 
> > > > > As Felix commented in the ticket, we already use just Adblock in a few
> > > places,
> > > > > so I would go for 1, since it's shorter
> > > > 
> > > > Agree, to be done.
> > > > 
> > > > > 
> > > > >
> > >
> https://codereview.adblockplus.org/29678581/diff/29678589/README.md#newcode85
> > > > > README.md:85: 
> > > > > Shouldn't this one stay as libadblockplus-binaries, since we're
> currently
> > > not
> > > > > renaming libadblockplus?
> > > > 
> > > > Right, it should remain "libadblockplus-binaries"
> > > 
> > > see patch set #2
> > 
> > LGTM
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5