Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1205)

Issue 29678657: Issue 4579 - Fix ESLint errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Manish Jethani
Modified:
1 year, 5 months ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M polyfill.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year, 5 months ago (2018-01-24 16:06:42 UTC) #1
Manish Jethani
Patch Set 1 This fixes the ESLint errors.
1 year, 5 months ago (2018-01-24 16:07:48 UTC) #2
kzar
Please could you reword the commit message to be more accurate, since we are not ...
1 year, 5 months ago (2018-01-24 16:15:12 UTC) #3
Manish Jethani
On 2018/01/24 16:15:12, kzar wrote: > Please could you reword the commit message to be ...
1 year, 5 months ago (2018-01-24 17:38:15 UTC) #4
kzar
1 year, 5 months ago (2018-01-24 17:48:54 UTC) #5
On 2018/01/24 17:38:15, Manish Jethani wrote:
> On 2018/01/24 16:15:12, kzar wrote:
> > Please could you reword the commit message to be more accurate, since we are
> not
> > only using an empty catch instead of finally and besides the reason for the
> > changes are to fix the ESLint errors.
> > 
> > Otherwise LGTM, thanks for fixing this.
> 
> OK, I've just changed it to "Issue 4579 - Fix ESLint errors". Looks OK?

Sure sounds good to me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5