Issue 29678657: Issue 4579 - Fix ESLint errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29678657: Issue 4579 - Fix ESLint errors (Closed)

Created:
Jan. 24, 2018, 4:06 p.m. by Manish Jethani

Modified:
Jan. 24, 2018, 5:59 p.m.

Reviewers:
kzar

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

Patch Set 1 #

Created: Jan. 24, 2018, 4:06 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	polyfill.js	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kzar

Please could you reword the commit message to be more accurate, since we are not ...

Jan. 24, 2018, 4:15 p.m. (2018-01-24 16:15:12 UTC) #3

Manish Jethani

On 2018/01/24 16:15:12, kzar wrote: > Please could you reword the commit message to be ...

Jan. 24, 2018, 5:38 p.m. (2018-01-24 17:38:15 UTC) #4

kzar

Jan. 24, 2018, 5:48 p.m. (2018-01-24 17:48:54 UTC) #5

On 2018/01/24 17:38:15, Manish Jethani wrote:
> On 2018/01/24 16:15:12, kzar wrote:
> > Please could you reword the commit message to be more accurate, since we are
> not
> > only using an empty catch instead of finally and besides the reason for the
> > changes are to fix the ESLint errors.
> > 
> > Otherwise LGTM, thanks for fixing this.
> 
> OK, I've just changed it to "Issue 4579 - Fix ESLint errors". Looks OK?

Sure sounds good to me

Expand All Messages | Collapse All Messages