[$csp3 adblockpluschrome] Issue 5241 - Avoid setting badge text before navigation is committed

Issue 5241 - Avoid setting badge text before navigation is committed
This one's necessary for the $csp filter type since Chrome resets the badge text after the page has finished loading, but by that point the $csp filter already matched.

Depends on:
 - https://codereview.adblockplus.org/29680684/
 - https://codereview.adblockplus.org/29680689/

[kzar, 2018-01-26 18:12:10]

Patch Set 1

[Sebastian Noack, 2018-03-06 19:14:13]

I did some testing, and it seems if you do it like this, you can remove the
ext.pages.onLoading listener:

  browser.webNavigation.onCommitted.addListener(details =>
  {
    let page = new ext.Page({id: details.tabId});
    let blocked = blockedPerPage.get(page);

    page.browserAction.setBadge(blocked && {
      color: badgeColor,
      number: blocked
    });
  });

[kzar, 2018-03-07 11:33:55]

Patch Set 2 : Remove onLoading listener

>  browser.webNavigation.onCommitted.addListener(details =>
>  {
>    let page = new ext.Page({id: details.tabId});
>    let blocked = blockedPerPage.get(page);
>
>    page.browserAction.setBadge(blocked && {
>      color: badgeColor,
>      number: blocked
>    });

Nice idea! Done.

[Sebastian Noack, 2018-03-07 16:55:27]

LGTM