Issue 29684561: Noissue - Use monospace font for code elements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29684561: Noissue - Use monospace font for code elements (Closed)

Created:
Jan. 30, 2018, 8:09 a.m. by ire

Modified:
Jan. 31, 2018, 1:24 p.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Noissue - Use monospace font for code elements

Patch Set 1 #

Patch Set 2 : Add style to pre element #

Created: Jan. 31, 2018, 11:35 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	static/scss/_content.scss	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

juliandoucette

LGTM + NIT this should probably apply to `pre` too.

Jan. 31, 2018, 1:51 a.m. (2018-01-31 01:51:11 UTC) #2

ire

On 2018/01/31 01:51:11, juliandoucette wrote: > LGTM + NIT this should probably apply to `pre` ...

Jan. 31, 2018, 11:36 a.m. (2018-01-31 11:36:20 UTC) #3

juliandoucette

LGTM The difference is (or can be) that code is inline and pre is block.

Jan. 31, 2018, 1 p.m. (2018-01-31 13:00:12 UTC) #4

ire

Jan. 31, 2018, 1:24 p.m. (2018-01-31 13:24:53 UTC) #5

Message was sent while issue was closed.

On 2018/01/31 13:00:12, juliandoucette wrote:
> LGTM
> 
> The difference is (or can be) that code is inline and pre is block.

Yes I know, I meant that the text within <pre> blocks are usually wrapped in
<code>s, so styling the <code> element itself is typically sufficient.

Expand All Messages | Collapse All Messages