Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29684561: Noissue - Use monospace font for code elements (Closed)

Created:
Jan. 30, 2018, 8:09 a.m. by ire
Modified:
Jan. 31, 2018, 1:24 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Use monospace font for code elements

Patch Set 1 #

Patch Set 2 : Add style to pre element #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M static/scss/_content.scss View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
ire
Jan. 30, 2018, 8:09 a.m. (2018-01-30 08:09:16 UTC) #1
juliandoucette
LGTM + NIT this should probably apply to `pre` too.
Jan. 31, 2018, 1:51 a.m. (2018-01-31 01:51:11 UTC) #2
ire
On 2018/01/31 01:51:11, juliandoucette wrote: > LGTM + NIT this should probably apply to `pre` ...
Jan. 31, 2018, 11:36 a.m. (2018-01-31 11:36:20 UTC) #3
juliandoucette
LGTM The difference is (or can be) that code is inline and pre is block.
Jan. 31, 2018, 1 p.m. (2018-01-31 13:00:12 UTC) #4
ire
Jan. 31, 2018, 1:24 p.m. (2018-01-31 13:24:53 UTC) #5
Message was sent while issue was closed.
On 2018/01/31 13:00:12, juliandoucette wrote:
> LGTM
> 
> The difference is (or can be) that code is inline and pre is block.

Yes I know, I meant that the text within <pre> blocks are usually wrapped in
<code>s, so styling the <code> element itself is typically sufficient.

Powered by Google App Engine
This is Rietveld