Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29684564: Issue 6320 - Add summary for adblock setting (Closed)

Created:
Jan. 30, 2018, 8:10 a.m. by anton
Modified:
May 3, 2018, 12:57 p.m.
Reviewers:
diegocarloslima, jens
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6320 - Add summary for adblock setting To be updated when http://hub.eyeo.com/issues/7442 is resolved by Tamara. Replaced by https://codereview.adblockplus.org/29684564.

Patch Set 1 #

Patch Set 2 : added summary for enable/disable switch #

Patch Set 3 : fixed typo #

Total comments: 4

Patch Set 4 : fixed capitalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M libadblockplus-android-settings/res/values/adblock_settings_strings.xml View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
M libadblockplus-android-settings/res/xml/preference_adblock_general.xml View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
anton
Jan. 30, 2018, 8:11 a.m. (2018-01-30 08:11:41 UTC) #1
jens
https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml File libadblockplus-android-settings/res/values/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml#newcode24 libadblockplus-android-settings/res/values/adblock_settings_strings.xml:24: <!-- Title of Preference to configure Whitelisted domains --> ...
Jan. 31, 2018, 8:14 a.m. (2018-01-31 08:14:59 UTC) #2
anton
https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml File libadblockplus-android-settings/res/values/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml#newcode24 libadblockplus-android-settings/res/values/adblock_settings_strings.xml:24: <!-- Title of Preference to configure Whitelisted domains --> ...
Jan. 31, 2018, 8:18 a.m. (2018-01-31 08:18:48 UTC) #3
jens
On 2018/01/31 08:18:48, anton wrote: > https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml > File libadblockplus-android-settings/res/values/adblock_settings_strings.xml > (right): > > https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-android-settings/res/values/adblock_settings_strings.xml#newcode24 ...
Jan. 31, 2018, 8:20 a.m. (2018-01-31 08:20:54 UTC) #4
diegocarloslima
Jan. 31, 2018, 4:52 p.m. (2018-01-31 16:52:51 UTC) #5 
On 2018/01/31 08:20:54, jens wrote:
> On 2018/01/31 08:18:48, anton wrote:
> >
>
https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-andr...
> > File libadblockplus-android-settings/res/values/adblock_settings_strings.xml
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-andr...
> > libadblockplus-android-settings/res/values/adblock_settings_strings.xml:24:
> <!--
> > Title of Preference to configure Whitelisted domains -->
> > On 2018/01/31 08:14:59, jens wrote:
> > > Minor, but 'whitelisted' should start with a small 'w' (like you did in
line
> > 30
> > > and 33)
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29684564/diff/29684617/libadblockplus-andr...
> > libadblockplus-android-settings/res/values/adblock_settings_strings.xml:27:
> <!--
> > Summary of Preference to configure Whitelisted domains -->
> > On 2018/01/31 08:14:59, jens wrote:
> > > Minor, but 'whitelisted' should start with a small 'w' (like you did in
line
> > 30
> > > and 33)
> > 
> > Acknowledged.
> > 
> > See patch set #4
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld