Noissue - fix native tests

meson.build

 project('adblockpluscore', 'cpp', license: ['GPL3'], meson_version: '>0.40.0')
 
 native = get_option('native')
 if native
    target_type='native'
 else
    target_type='js'
 endif
 
 if target_type == 'js'
@@ skipping 22 matching lines @@
   endif
   nodejs = find_program(command.stdout().strip(), 'node', 'nodejs')
 endif
 
 JS_LIBRARY = files(join_paths('compiled', 'library.js'))
 BINDINGS_JS_LIBRARY = files(join_paths('compiled', 'bindings', 'library.js'))
 BINDINGS_GENERATOR = 'bindings.cpp.js'
 BINDINGS_OUTPUT = 'bindings.js'
 COMPILER_OUTPUT = 'compiled.js'
 # params for emcc compilation
 ADDITIONAL_PARAMS = [ '-O3', '-std=c++1z', '-Wall', '-Werror',

[sergei, 2018/01/30 14:29:10]

-Werror should be also removed because there are warnings but I think it should
be addresses in another codereview and actually it's in our code.

[hub, 2018/01/30 15:13:22]

FWIW I have no warnings here. But I agree on removing -Werror.

[sergei, 2018/01/30 15:21:52]

I really want to have a project without warnings but perhaps I agree with
removing -Werror because on practice it does not work because warnings can just
appear with a different version of a compiler and it does not mean that the
everything should be stopped immediately.

                       '-fno-rtti' ]
 if target_type == 'js'
 # CXXFLAGS specific to emcc
   ADDITIONAL_PARAMS += [ '-m32', '--memory-init-file', '0',
                          '--emit-symbol-map' ]
 else
   ADDITIONAL_PARAMS += [ '-fsanitize=address' ]
 endif
 # additional params just for core
 CORE_PARAMS = [ '-fno-exceptions' ]
@@ skipping 131 matching lines @@
                                   input: core_objects + shared_objects,
                                   output: COMPILER_OUTPUT,
                                   depend_files: [ JS_LIBRARY ],
                                   command: [
                                     emcc, '-o', output_file,
                                     '--post-js', bindings_output,
                                     '--js-library', JS_LIBRARY,
                                     '@INPUT@'
                                   ] + compiler_args + optional_args)
 else
-  GTEST_DIR = join_paths('third-party', 'googletest', 'googletest')
+  GTEST_DIR = join_paths('third_party', 'googletest', 'googletest')

[hub, 2018/01/30 15:13:22]

*sigh* there was a change at one point (when I added the dependency) and because
it didn't get cleaned I never realized this was broken.

   GTEST_PARAMS = []
   compiler = meson.get_compiler('cpp')
   if compiler.has_argument('-pthread')
     GTEST_PARAMS += '-pthread'
+    LINK_PARAMS += '-lpthread'
   endif
 
   test_sources = [
     'test/compiled/abptest.cpp',
     'test/compiled/String.cpp',
     'test/compiled/StringMap.cpp',
     'test/compiled/RegExp.cpp',
   ]
 
   adblockpluscore = library('adblockpluscore', shared_sources,
                             native_sources,
                             cpp_args: ADDITIONAL_PARAMS + CORE_PARAMS,
                             link_args: LINK_PARAMS)
   gtest = static_library('gtest', files(join_paths(GTEST_DIR, 'src', 'gtest-all.cc')),
                          include_directories: [
                              include_directories(join_paths(GTEST_DIR, 'include'), is_system: true),
                              include_directories(GTEST_DIR)
                          ],
                          cpp_args: GTEST_PARAMS)
   abptest = executable('abptest', test_sources,
                        cpp_args: ADDITIONAL_PARAMS + CORE_PARAMS,
                        include_directories: include_directories(join_paths(GTEST_DIR, 'include')),
                        link_args: LINK_PARAMS,
                        link_with: [ adblockpluscore, gtest ])
   test('abptest', abptest)
 endif