Issue 29684686: Noissue - fix native tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29684686: Noissue - fix native tests (Closed)

Created:
Jan. 30, 2018, 2:26 p.m. by sergei

Modified:
Jan. 30, 2018, 3:21 p.m.

Reviewers:
hub

Base URL:
github.com:adblockplus/adblockpluscore

Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29684686

Patch Set 1 #

Total comments: 4

Created: Jan. 30, 2018, 2:26 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	meson.build	View		1 chunk	+2 lines, -1 line	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

sergei

https://codereview.adblockplus.org/29684686/diff/29684687/meson.build File meson.build (right): https://codereview.adblockplus.org/29684686/diff/29684687/meson.build#newcode43 meson.build:43: ADDITIONAL_PARAMS = [ '-O3', '-std=c++1z', '-Wall', '-Werror', -Werror should ...

Jan. 30, 2018, 2:29 p.m. (2018-01-30 14:29:10 UTC) #1

hub

LGTM https://codereview.adblockplus.org/29684686/diff/29684687/meson.build File meson.build (right): https://codereview.adblockplus.org/29684686/diff/29684687/meson.build#newcode43 meson.build:43: ADDITIONAL_PARAMS = [ '-O3', '-std=c++1z', '-Wall', '-Werror', On ...

Jan. 30, 2018, 3:13 p.m. (2018-01-30 15:13:23 UTC) #2

sergei

Jan. 30, 2018, 3:21 p.m. (2018-01-30 15:21:52 UTC) #3

Message was sent while issue was closed.

https://codereview.adblockplus.org/29684686/diff/29684687/meson.build
File meson.build (right):

https://codereview.adblockplus.org/29684686/diff/29684687/meson.build#newcode43
meson.build:43: ADDITIONAL_PARAMS = [ '-O3', '-std=c++1z', '-Wall', '-Werror',
On 2018/01/30 15:13:22, hub wrote:
> On 2018/01/30 14:29:10, sergei wrote:
> > -Werror should be also removed because there are warnings but I think it
> should
> > be addresses in another codereview and actually it's in our code.
> 
> FWIW I have no warnings here. But I agree on removing -Werror.

I really want to have a project without warnings but perhaps I agree with
removing -Werror because on practice it does not work because warnings can just
appear with a different version of a compiler and it does not mean that the
everything should be stopped immediately.

Expand All Messages | Collapse All Messages