Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29684695: Issue 6287 - Create codename Orca v.0 to launch internally to the team (Closed)

Created:
Jan. 30, 2018, 4:52 p.m. by jens
Modified:
Feb. 21, 2018, 9:26 a.m.
Reviewers:
diegocarloslima, anton
CC:
René Jeschke, Felix Dahlke, Oleksandr, sergei, hub
Visibility:
Public.

Description

Issue 6287 - Create codename Orca v.0 to launch internally to the team

Patch Set 1 #

Patch Set 2 : Added basic versioning #

Total comments: 6

Patch Set 3 : Added link to issue and adjusted versionName #

Total comments: 4

Patch Set 4 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
A build/config/android/version.gni View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/android/java/res_orca/drawable-hdpi/fre_product_logo.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-hdpi/product_logo_name.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-mdpi/fre_product_logo.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-mdpi/product_logo_name.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xhdpi/fre_product_logo.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xhdpi/product_logo_name.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xxhdpi/fre_product_logo.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xxhdpi/product_logo_name.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xxxhdpi/fre_product_logo.png View Binary file 0 comments Download
A chrome/android/java/res_orca/drawable-xxxhdpi/product_logo_name.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-hdpi/app_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-hdpi/app_shortcut_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-hdpi/app_single_page_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-mdpi/app_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-mdpi/app_shortcut_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-mdpi/app_single_page_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xhdpi/app_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xhdpi/app_single_page_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxhdpi/app_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxhdpi/app_single_page_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxxhdpi/app_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A chrome/android/java/res_orca/mipmap-xxxhdpi/app_single_page_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_orca/values/channel_constants.xml View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9
jens
Jan. 30, 2018, 4:55 p.m. (2018-01-30 16:55:29 UTC) #1
anton
On 2018/01/30 16:55:29, jens wrote: Minor note (not mentioned in the ticket) - what about ...
Jan. 31, 2018, 5:48 a.m. (2018-01-31 05:48:02 UTC) #2
jens
On 2018/01/31 05:48:02, anton wrote: > On 2018/01/30 16:55:29, jens wrote: > > Minor note ...
Jan. 31, 2018, 4:48 p.m. (2018-01-31 16:48:37 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29684695/diff/29685593/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.adblockplus.org/29684695/diff/29685593/chrome/android/BUILD.gn#newcode978 chrome/android/BUILD.gn:978: # Change res directory for rebranding. See https://issues.adblockplus.org/ticket/6287 The ...
Jan. 31, 2018, 5:48 p.m. (2018-01-31 17:48:45 UTC) #4
anton
https://codereview.adblockplus.org/29684695/diff/29685593/build/config/android/version.gni File build/config/android/version.gni (right): https://codereview.adblockplus.org/29684695/diff/29685593/build/config/android/version.gni#newcode5 build/config/android/version.gni:5: android_version_name = "Orca Alpha 1" i think "Orca" relates ...
Feb. 1, 2018, 5:34 a.m. (2018-02-01 05:34:44 UTC) #5
jens
Added a new patch set https://codereview.adblockplus.org/29684695/diff/29685593/build/config/android/version.gni File build/config/android/version.gni (right): https://codereview.adblockplus.org/29684695/diff/29685593/build/config/android/version.gni#newcode5 build/config/android/version.gni:5: android_version_name = "Orca Alpha ...
Feb. 1, 2018, 8:54 a.m. (2018-02-01 08:54:52 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUILD.gn#newcode987 chrome/android/BUILD.gn:987: # Change res directory for rebranding. See https://issues.adblockplus.org/ticket/6287 This ...
Feb. 1, 2018, 10:05 a.m. (2018-02-01 10:05:59 UTC) #7
jens
patch set #4 https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUILD.gn#newcode987 chrome/android/BUILD.gn:987: # Change res directory for rebranding. ...
Feb. 1, 2018, 10:12 a.m. (2018-02-01 10:12:57 UTC) #8
diegocarloslima
Feb. 5, 2018, 5:57 p.m. (2018-02-05 17:57:04 UTC) #9 
On 2018/02/01 10:12:57, jens wrote:
> patch set #4
> 
>
https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUIL...
> File chrome/android/BUILD.gn (right):
> 
>
https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUIL...
> chrome/android/BUILD.gn:987: # Change res directory for rebranding. See
> https://issues.adblockplus.org/ticket/6287
> On 2018/02/01 10:05:58, diegocarloslima wrote:
> > This comment should also be 'Change APK name'
> 
> Acknowledged.
> 
>
https://codereview.adblockplus.org/29684695/diff/29686558/chrome/android/BUIL...
> chrome/android/BUILD.gn:1114: # Change res directory for rebranding. See
> https://issues.adblockplus.org/ticket/6287
> On 2018/02/01 10:05:58, diegocarloslima wrote:
> > This comment should also be 'Change APK name'
> 
> Acknowledged.

LGTM

Powered by Google App Engine
This is Rietveld