Noissue - Allow displaying String in tests

Noissue - Allow displaying String in tests

[hub, 2018-01-31 20:47:36]

It doesn't handle non-ASCII properly but it's good enough to *display* from
TEST_EQ().

[sergei, 2018-02-01 16:10:46]

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h
File compiled/String.h (right):

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:24: #include <iostream>
Could you please wrap it by #ifdef INSIDE_TESTS too?

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:201: os << static_cast<char>(str[i]);
Even for tests I would like to have a helper function which converts from UCS2
to UTF-8 (the implementation can be based on
http://en.cppreference.com/w/cpp/locale/wstring_convert/to_bytes), and one could
call this function here.

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:271: inline std::ostream& operator<<(std::ostream& os, const
DependentString& str)
It should not be required.

[hub, 2018-02-01 19:16:30]

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h
File compiled/String.h (right):

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:24: #include <iostream>
On 2018/02/01 16:10:46, sergei wrote:
> Could you please wrap it by #ifdef INSIDE_TESTS too?

Done.

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:201: os << static_cast<char>(str[i]);
On 2018/02/01 16:10:46, sergei wrote:
> Even for tests I would like to have a helper function which converts from UCS2
> to UTF-8 (the implementation can be based on
> http://en.cppreference.com/w/cpp/locale/wstring_convert/to_bytes), and one
could
> call this function here.

Done

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:271: inline std::ostream& operator<<(std::ostream& os, const
DependentString& str)
On 2018/02/01 16:10:46, sergei wrote:
> It should not be required.

Without this it operator<< doesn't get called, unless I actually cast to const
String& on the TEST_EQ() call.

To be complete I'd need to do the same for OwnedString.

[sergei, 2018-02-02 15:03:32]

LGTM

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h
File compiled/String.h (right):

https://codereview.adblockplus.org/29685634/diff/29685635/compiled/String.h#n...
compiled/String.h:271: inline std::ostream& operator<<(std::ostream& os, const
DependentString& str)
On 2018/02/01 19:16:30, hub wrote:
> On 2018/02/01 16:10:46, sergei wrote:
> > It should not be required.
> 
> Without this it operator<< doesn't get called, unless I actually cast to const
> String& on the TEST_EQ() call.
> 
> To be complete I'd need to do the same for OwnedString.

Acknowledged. I think it is worth investigation, because it's strange. BTW, I
have tried PrintTo and it does not work at all.