Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29686631: Issue 4579, 6343 - Let errors from wrapped API calls bubble up (Closed)

Created:
Feb. 1, 2018, 7:46 p.m. by Manish Jethani
Modified:
Feb. 6, 2018, 12:20 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M polyfill.js View 1 chunk +28 lines, -22 lines 2 comments Download

Messages

Total messages: 5
Manish Jethani
Feb. 1, 2018, 7:46 p.m. (2018-02-01 19:46:14 UTC) #1
Manish Jethani
Patch Set 1 See my comment here: https://issues.adblockplus.org/ticket/4579#comment:34
Feb. 1, 2018, 7:48 p.m. (2018-02-01 19:48:12 UTC) #2
kzar
https://codereview.adblockplus.org/29686631/diff/29686632/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/29686631/diff/29686632/polyfill.js#newcode123 polyfill.js:123: resolvePromise(result); I wonder if it could be possible that ...
Feb. 6, 2018, 9:49 a.m. (2018-02-06 09:49:24 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29686631/diff/29686632/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/29686631/diff/29686632/polyfill.js#newcode123 polyfill.js:123: resolvePromise(result); On 2018/02/06 09:49:24, kzar wrote: > I wonder ...
Feb. 6, 2018, 11:51 a.m. (2018-02-06 11:51:38 UTC) #4
kzar
Feb. 6, 2018, 11:57 a.m. (2018-02-06 11:57:14 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld