Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29687568: Issue 6345 - Implement translations for manual subscription update (Closed)

Created:
Feb. 2, 2018, 11:04 a.m. by jens
Modified:
Feb. 8, 2018, 10:33 a.m.
Reviewers:
diegocarloslima, anton
Visibility:
Public.

Description

Issue 6345 - Implement translations for manual subscription update

Patch Set 1 : #

Patch Set 2 : Changed string after update from agency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M adblockplussbrowser/res/values-de/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-el/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-es/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-fr/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-it/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-ko/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-nl/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-pl/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-pt/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-ru/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-tr/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jens
Feb. 2, 2018, 11:21 a.m. (2018-02-02 11:21:38 UTC) #1
anton
On 2018/02/02 11:21:38, jens wrote: LGTM
Feb. 2, 2018, 11:28 a.m. (2018-02-02 11:28:26 UTC) #2
diegocarloslima
On 2018/02/02 11:28:26, anton wrote: > On 2018/02/02 11:21:38, jens wrote: > > LGTM LGTM
Feb. 5, 2018, 5:49 p.m. (2018-02-05 17:49:13 UTC) #3
jens
Feb. 6, 2018, 12:20 p.m. (2018-02-06 12:20:30 UTC) #4
On 2018/02/05 17:49:13, diegocarloslima wrote:
> On 2018/02/02 11:28:26, anton wrote:
> > On 2018/02/02 11:21:38, jens wrote:
> > 
> > LGTM
> 
> LGTM

Please note Tamaras comment in this ticket: http://hub.eyeo.com/issues/7195
I had to update one word in the italian strings.

Powered by Google App Engine
This is Rietveld