Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1288)

Issue 29687593: Issue 6335 - Update translations for "Samsung Internet" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by jens
Modified:
1 year, 5 months ago
Reviewers:
anton, diegocarloslima
Visibility:
Public.

Description

Issue 6335 - Update translations for "Samsung Internet"

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added missing translations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M adblockplussbrowser/res/values-es/strings.xml View 1 2 chunks +7 lines, -7 lines 0 comments Download
M adblockplussbrowser/res/values-it/strings.xml View 1 2 chunks +7 lines, -7 lines 0 comments Download
M adblockplussbrowser/res/values-ru/strings.xml View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5
jens
1 year, 5 months ago (2018-02-02 11:21:28 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser/res/values-it/strings.xml File adblockplussbrowser/res/values-it/strings.xml (left): https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser/res/values-it/strings.xml#oldcode25 adblockplussbrowser/res/values-it/strings.xml:25: <string name="setup_dialog_title">Abilitare Adblock Plus in Samsung Internet</string> 'Samsung Internet' ...
1 year, 5 months ago (2018-02-05 17:44:16 UTC) #2
jens
New patch set https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser/res/values-it/strings.xml File adblockplussbrowser/res/values-it/strings.xml (left): https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser/res/values-it/strings.xml#oldcode25 adblockplussbrowser/res/values-it/strings.xml:25: <string name="setup_dialog_title">Abilitare Adblock Plus in Samsung ...
1 year, 5 months ago (2018-02-06 08:04:44 UTC) #3
anton
On 2018/02/06 08:04:44, jens wrote: > New patch set > > https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser/res/values-it/strings.xml > File adblockplussbrowser/res/values-it/strings.xml ...
1 year, 5 months ago (2018-02-07 14:34:29 UTC) #4
diegocarloslima
1 year, 5 months ago (2018-02-07 14:49:07 UTC) #5
On 2018/02/07 14:34:29, anton wrote:
> On 2018/02/06 08:04:44, jens wrote:
> > New patch set
> > 
> >
>
https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser...
> > File adblockplussbrowser/res/values-it/strings.xml (left):
> > 
> >
>
https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser...
> > adblockplussbrowser/res/values-it/strings.xml:25: <string
> > name="setup_dialog_title">Abilitare Adblock Plus in Samsung
Internet</string>
> > On 2018/02/05 17:44:16, diegocarloslima wrote:
> > > 'Samsung Internet' should be changed to 'Internet Samsung' here
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser...
> > File adblockplussbrowser/res/values-ru/strings.xml (left):
> > 
> >
>
https://codereview.adblockplus.org/29687593/diff/29687594/adblockplussbrowser...
> > adblockplussbrowser/res/values-ru/strings.xml:25: <string
> > name="setup_dialog_title">Включите Adblock Plus в Samsung Internet</string>
> > On 2018/02/05 17:44:16, diegocarloslima wrote:
> > > Seems that this one should be changed as well
> > 
> > Acknowledged.
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5