Fixes #4 - Update primary and footer navigation contents

Fixes #4 - https://gitlab.com/eyeo/web.adblockplus.org/issues/4

Branch: index_page

[ire, 2018-02-05 09:48:50]

@Manvel could you please take a look at this when you can?

[saroyanm, 2018-02-05 15:44:11]

Just two clarification questions.

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmpl
File includes/navbar.tmpl (left):

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmp...
includes/navbar.tmpl:17: {% for pagename in ["about", "features", "bugs",
"contribute"] %}
In the Issue it says:
"Features are getting merged on to the homepage", I can't see that moved into
the homepage, or am I missing something ?

According to the issue, the features link is not redundant until features are
moved to homepage.

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmp...
includes/navbar.tmpl:17: {% for pagename in ["about", "features", "bugs",
"contribute"] %}
What was the reason of making the Issue reporting less accessible ?

I can ask that in the issue itself, I assume this was run through the QA team as
well?

[ire, 2018-02-05 16:15:02]

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmpl
File includes/navbar.tmpl (left):

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmp...
includes/navbar.tmpl:17: {% for pagename in ["about", "features", "bugs",
"contribute"] %}
On 2018/02/05 15:44:10, saroyanm wrote:
> In the Issue it says:
> "Features are getting merged on to the homepage", I can't see that moved into
> the homepage, or am I missing something ?
> 
> According to the issue, the features link is not redundant until features are
> moved to homepage.

Yes, this change will not be pushed to master until all the changes in the
milestone are completed. 

See milestone -
https://gitlab.com/eyeo/web.adblockplus.org/issues?milestone_title=adblockplu...

https://codereview.adblockplus.org/29689571/diff/29689572/includes/navbar.tmp...
includes/navbar.tmpl:17: {% for pagename in ["about", "features", "bugs",
"contribute"] %}
On 2018/02/05 15:44:10, saroyanm wrote:
> What was the reason of making the Issue reporting less accessible ?
> 
> I can ask that in the issue itself, I assume this was run through the QA team
as
> well?

Yes it's been through the QA team. I don't know specifically the reason for
removing it, but as you said you can bring it up in the issue for clarification.

[saroyanm, 2018-02-06 12:02:50]

Implementation wise: LGTM
While QA have reviewed the move of the Issue Reporter from the header and
Features implementation will be moved to the Homepage, before pushing to master,
I think review can be considered ready.

[ire, 2018-02-06 14:26:47]

On 2018/02/06 12:02:50, saroyanm wrote:
> Implementation wise: LGTM
> While QA have reviewed the move of the Issue Reporter from the header and
> Features implementation will be moved to the Homepage, before pushing to
master,
> I think review can be considered ready.

Thanks! I'll continue with this commit to the index_page branch, but we should
have gotten concrete feedback on this issue before the index_page commits merge
to master anyway

[juliandoucette, 2018-02-13 18:10:46]

Not LGTM

Backout - https://hg.adblockplus.org/web.adblockplus.org/rev/640dffec0e12

See https://gitlab.com/eyeo/web.adblockplus.org/issues/4#note_58900251