Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29690863: Issue 6360 - Add support of MSVS (Closed)

Created:
Feb. 6, 2018, 12:59 p.m. by sergei
Modified:
Feb. 7, 2018, 2:47 p.m.
Reviewers:
hub
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M compiled/subscription/Subscription.cpp View 2 chunks +3 lines, -2 lines 1 comment Download
M meson.build View 6 chunks +32 lines, -14 lines 0 comments Download

Messages

Total messages: 4
sergei
It's merely the first step getting it working, I plan to make following changes when ...
Feb. 6, 2018, 1:07 p.m. (2018-02-06 13:07:29 UTC) #1
hub
my question is how do you set the compile option on MSVC?
Feb. 6, 2018, 2:51 p.m. (2018-02-06 14:51:27 UTC) #2
sergei
On 2018/02/06 14:51:27, hub wrote: > my question is how do you set the compile ...
Feb. 6, 2018, 2:59 p.m. (2018-02-06 14:59:18 UTC) #3
hub
Feb. 6, 2018, 3 p.m. (2018-02-06 15:00:34 UTC) #4
On 2018/02/06 14:59:18, sergei wrote:
> On 2018/02/06 14:51:27, hub wrote:
> > my question is how do you set the compile option on MSVC?
> 
> I'm not setting yet but meson is already smart enough to set few of them, in
> particular it generates different compile options for release and debug
> buildtypes, and it works for both backends vs2017 and ninja.
> 
> If we need to tune some options then we can use "cpp_args", it does work.

ok. LGTM

Powered by Google App Engine
This is Rietveld