Issue 29691582: Issue 6366 - Elemhide thread is accessing released engine

Issue 29691582: Issue 6366 - Elemhide thread is accessing released engine (Closed)

Created:
Feb. 7, 2018, 1:48 p.m. by anton

Modified:
Feb. 7, 2018, 2:24 p.m.

Reviewers:
diegocarloslima, jens

CC:
vicky, sergei

Visibility:
Public.

Description

Issue 6366 - Elemhide thread is accessing released engine

Patch Set 3 : added "final" #

Created: Feb. 7, 2018, 2:02 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -163 lines)			Patch
M	libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java	View		2 chunks	+124 lines, -118 lines	0 comments	Download
M	libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngineProvider.java	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java	View	1 2	5 chunks	+62 lines, -45 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

diegocarloslima

https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java File libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java (right): https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java#newcode823 libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java:823: // if dispose() was invoke, but the page is ...

Feb. 7, 2018, 2 p.m. (2018-02-07 14:00:06 UTC) #2

jens

https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java (right): https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java#newcode61 libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java:61: private Object engineLock = new Object(); Could be final

Feb. 7, 2018, 2:01 p.m. (2018-02-07 14:01:23 UTC) #3

anton

Feb. 7, 2018, 2:03 p.m. (2018-02-07 14:03:23 UTC) #4

jens

On 2018/02/07 14:03:23, anton wrote: > https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java > File > libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java > (right): > > ...

Feb. 7, 2018, 2:04 p.m. (2018-02-07 14:04:21 UTC) #5

diegocarloslima

Feb. 7, 2018, 2:04 p.m. (2018-02-07 14:04:50 UTC) #6

On 2018/02/07 14:03:23, anton wrote:
>
https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-andr...
> File
>
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
> (right):
> 
>
https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-andr...
>
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java:823:
> // if dispose() was invoke, but the page is still loading then just let it go
> On 2018/02/07 14:00:06, diegocarloslima wrote:
> > Not really related to the issue, but it seems that it should be 'invoked'
here
> 
> Yes, it should be `invoked`.
> Not fixing now as it's not related change.
> 
>
https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-andr...
> File
>
libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java
> (right):
> 
>
https://codereview.adblockplus.org/29691582/diff/29691583/libadblockplus-andr...
>
libadblockplus-android/src/org/adblockplus/libadblockplus/android/SingleInstanceEngineProvider.java:61:
> private Object engineLock = new Object();
> On 2018/02/07 14:01:23, jens wrote:
> > Could be final
> 
> Acknowledged.
> 
> See patch set #3

LGTM

Expand All Messages | Collapse All Messages