Issue 6365 - dispose v8::Isolate with a long enough delay

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 67 matching lines @@
 }
 
 AdblockPlus::ScopedV8Isolate::ScopedV8Isolate()
 {
   V8Initializer::Init();
   isolate = v8::Isolate::New();
 }
 
 AdblockPlus::ScopedV8Isolate::~ScopedV8Isolate()
 {
-  isolate->Dispose();
+  auto capturedIsolatePtr = isolate;
+  std::thread([capturedIsolatePtr]{

[anton, 2018/02/07 14:43:12]

shouldn't  `{`it be on the next line?

[sergei, 2018/02/07 14:54:20]

Done.

+    std::chrono::seconds timeout(60 * 10);
+    std::this_thread::sleep_for(timeout);
+    capturedIsolatePtr->Dispose();
+  }).detach();
   isolate = nullptr;
 }
 
 JsEngine::JsWeakValuesList::~JsWeakValuesList()
 {
   for (auto& value : values)
     value->Dispose();
 }
 
 void JsEngine::NotifyLowMemory()
@@ skipping 240 matching lines @@
   logSystem = val;
 }
 
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
   global.SetProperty(name, value);
 }