Issue 29691607: Issue 6365 - dispose v8::Isolate with a long enough delay

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29691607: Issue 6365 - dispose v8::Isolate with a long enough delay (Closed)

Created:
Feb. 7, 2018, 2:26 p.m. by sergei

Modified:
Feb. 7, 2018, 3:02 p.m.

Reviewers:
anton, hub, Oleksandr

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

# It's based on git:a34532c2f3f9132b0bf0be48f221d3679d146581 # I didn't manage to compile V8 BTW because I don't have such old g++ for present.

Patch Set 2 : fix coding style #

Created: Feb. 7, 2018, 2:54 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/JsEngine.cpp	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sergei

As discussed in IRC it's a very dirty hack but it should be good enough ...

Feb. 7, 2018, 2:29 p.m. (2018-02-07 14:29:33 UTC) #1

anton

https://codereview.adblockplus.org/29691607/diff/29691608/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29691607/diff/29691608/src/JsEngine.cpp#newcode89 src/JsEngine.cpp:89: std::thread([capturedIsolatePtr]{ shouldn't `{`it be on the next line?

Feb. 7, 2018, 2:43 p.m. (2018-02-07 14:43:13 UTC) #2

sergei

Feb. 7, 2018, 2:54 p.m. (2018-02-07 14:54:20 UTC) #3

anton

Feb. 7, 2018, 2:55 p.m. (2018-02-07 14:55:11 UTC) #4

On 2018/02/07 14:54:20, sergei wrote:
> https://codereview.adblockplus.org/29691607/diff/29691608/src/JsEngine.cpp
> File src/JsEngine.cpp (right):
> 
>
https://codereview.adblockplus.org/29691607/diff/29691608/src/JsEngine.cpp#ne...
> src/JsEngine.cpp:89: std::thread([capturedIsolatePtr]{
> On 2018/02/07 14:43:12, anton wrote:
> > shouldn't  `{`it be on the next line?
> 
> Done.

LGTM

Expand All Messages | Collapse All Messages