Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29695640: Issue 6281 - Don't return deleted entries (Closed)

Created:
Feb. 12, 2018, 11:52 p.m. by hub
Modified:
Feb. 13, 2018, 3:50 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6281 - Don't return deleted entries

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused comment. #

Total comments: 2

Patch Set 3 : Remove mistakenly added characters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M compiled/ElemHide.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M compiled/ElemHideEmulation.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M compiled/Map.h View 4 chunks +4 lines, -4 lines 0 comments Download
M test/compiled/StringMap.cpp View 1 2 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 6
hub
Feb. 12, 2018, 11:52 p.m. (2018-02-12 23:52:55 UTC) #1
sergei
https://codereview.adblockplus.org/29695640/diff/29695641/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29695640/diff/29695641/test/compiled/StringMap.cpp#newcode64 test/compiled/StringMap.cpp:64: // XXX should be 4. it seems this comment ...
Feb. 13, 2018, 9:06 a.m. (2018-02-13 09:06:39 UTC) #2
hub
https://codereview.adblockplus.org/29695640/diff/29695641/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29695640/diff/29695641/test/compiled/StringMap.cpp#newcode64 test/compiled/StringMap.cpp:64: // XXX should be 4. On 2018/02/13 09:06:39, sergei ...
Feb. 13, 2018, 2:46 p.m. (2018-02-13 14:46:29 UTC) #3
sergei
https://codereview.adblockplus.org/29695640/diff/29696578/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29695640/diff/29696578/test/compiled/StringMap.cpp#newcode48 test/compiled/StringMap.cpp:48: rr map[u"Foobar2"_str] = "two"; could you please also remove ...
Feb. 13, 2018, 3:01 p.m. (2018-02-13 15:01:39 UTC) #4
hub
https://codereview.adblockplus.org/29695640/diff/29696578/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29695640/diff/29696578/test/compiled/StringMap.cpp#newcode48 test/compiled/StringMap.cpp:48: rr map[u"Foobar2"_str] = "two"; On 2018/02/13 15:01:39, sergei wrote: ...
Feb. 13, 2018, 3:08 p.m. (2018-02-13 15:08:44 UTC) #5
sergei
Feb. 13, 2018, 3:17 p.m. (2018-02-13 15:17:43 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld