Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 29696596: Issue 6383 - introduce switchable app_id (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by tlucas
Modified:
3 months ago
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/buildtools/rev/097b8d9c43a8
Visibility:
Public.

Description

Issue 6383 - introduce switchable app_id This patch enables overwriting an extensions' manifests' application-id with a given "beta_id". Note that the "updateURL"-machinery is already given (and will be adjusted / added for the sake of #6371 when adblockpluschrome's buildtools dependency is updated.)

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M packager.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M packagerChrome.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M packagerEdge.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M templates/manifest.json.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_gecko_development_build.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/metadata.gecko View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
tlucas
Patch Set 1 Adding "beta_id" support.
3 months ago (2018-02-13 15:54:12 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest.json.tmpl File templates/manifest.json.tmpl (right): https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest.json.tmpl#newcode36 templates/manifest.json.tmpl:36: {%- set extension_id = 'beta_id' if not releaseBuild and ...
3 months ago (2018-02-13 16:11:53 UTC) #2
tlucas
Patch Set 2 Moved logic for switchable app-id to packager.py, using it in edge and ...
3 months ago (2018-02-14 10:51:48 UTC) #3
Sebastian Noack
3 months ago (2018-02-14 11:26:16 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5