Issue 6383 - introduce switchable app_id

Issue 6383 - introduce switchable app_id

This patch enables overwriting an extensions' manifests' application-id with a given "beta_id".
Note that the "updateURL"-machinery is already given (and will be adjusted / added for the sake of #6371 when adblockpluschrome's buildtools dependency is updated.)

[tlucas, 2018-02-13 15:54:12]

Patch Set 1

Adding "beta_id" support.

[Sebastian Noack, 2018-02-13 16:11:53]

https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest....
File templates/manifest.json.tmpl (right):

https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest....
templates/manifest.json.tmpl:36: {%- set extension_id = 'beta_id' if not
releaseBuild and not devenv and metadata.has_option('general', 'beta_id') else
'id' %}
We have similar logic already for the Edge builds. Perhaps it makes sense to
implement it consistently here, i.e. call the option id_release and id_devbuild,
and move the logic into the packager.

[tlucas, 2018-02-14 10:51:48]

Patch Set 2

Moved logic for switchable app-id to packager.py, using it in edge and gecko
builds.

https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest....
File templates/manifest.json.tmpl (right):

https://codereview.adblockplus.org/29696596/diff/29696598/templates/manifest....
templates/manifest.json.tmpl:36: {%- set extension_id = 'beta_id' if not
releaseBuild and not devenv and metadata.has_option('general', 'beta_id') else
'id' %}
On 2018/02/13 16:11:52, Sebastian Noack wrote:
> We have similar logic already for the Edge builds. Perhaps it makes sense to
> implement it consistently here, i.e. call the option id_release and
id_devbuild,
> and move the logic into the packager.

Good point - Done.

[Sebastian Noack, 2018-02-14 11:26:16]

LGTM