packagerEdge.py - Issue 29696596: Issue 6383 - introduce switchable app_id

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerEdge.py

Issue 29696596: Issue 6383 - introduce switchable app_id (Closed) Base URL: https://hg.adblockplus.org/buildtools/rev/097b8d9c43a8

Patch Set: Created Feb. 14, 2018, 10:49 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerEdge.py

diff --git a/packagerEdge.py b/packagerEdge.py

index 766baae91807072a50a5bfa7aa91b723071f99dc..869db38062e12665420b1cec959894ad5c2503f6 100644

--- a/packagerEdge.py

+++ b/packagerEdge.py

@@ -99,8 +99,7 @@ def create_appx_manifest(params, files, build_num, release_build):

else:

params['app_extension_id'] = 'EdgeExtension'

- app_id = 'app_id_' + metadata_suffix

- params['app_id'] = metadata.get('general', app_id)

+ params['app_id'] = packager.get_app_id(release_build, metadata)

translation = load_translation(files, defaultLocale)

name_key = 'name' if release_build else 'name_devbuild'

« no previous file with comments | « packagerChrome.py ('k') | templates/manifest.json.tmpl » ('j') | no next file with comments »