Issue 29697671: Issue 6183 - Avoid attempting to close the composer popup twice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29697671: Issue 6183 - Avoid attempting to close the composer popup twice (Closed)

Created:
Feb. 14, 2018, 4:18 p.m. by kzar

Modified:
Feb. 20, 2018, 12:33 p.m.

Reviewers:
Manish Jethani

CC:
Sebastian Noack

Visibility:
Public.

Description

Issue 6183 - Avoid attempting to close the composer popup twice

Patch Set 1 #

Total comments: 3

Created: Feb. 14, 2018, 4:18 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	composer.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	composer.postload.js	View		4 chunks	+6 lines, -6 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Manish Jethani

https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.js File composer.postload.js (right): https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.js#newcode569 composer.postload.js:569: popupAlreadyClosed: true We could just call this "dialogClosed" (instead ...

Feb. 20, 2018, 11:17 a.m. (2018-02-20 11:17:31 UTC) #2

kzar

https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.js File composer.postload.js (right): https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.js#newcode569 composer.postload.js:569: popupAlreadyClosed: true On 2018/02/20 11:17:30, Manish Jethani wrote: > ...

Feb. 20, 2018, 11:56 a.m. (2018-02-20 11:56:44 UTC) #3

Manish Jethani

Feb. 20, 2018, 12:33 p.m. (2018-02-20 12:33:25 UTC) #4

Message was sent while issue was closed.

https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.js
File composer.postload.js (right):

https://codereview.adblockplus.org/29697671/diff/29697672/composer.postload.j...
composer.postload.js:569: popupAlreadyClosed: true
On 2018/02/20 11:56:44, kzar wrote:
> On 2018/02/20 11:17:30, Manish Jethani wrote:
> > We could just call this "dialogClosed" (instead of "popupAlreadyClosed") to
> use
> > consistent terminology, i.e. composer.dialog.close,
> > composer.content.dialogClosed, etc.
> 
> FWIW I prefer popupAlreadyClosed so I went with that, but I can see the
argument
> either way.

Sounds good, thanks.

Expand All Messages | Collapse All Messages