Noissue - Abstracted embedded video for use in blog

includes/scripts/initialize-videos.html

Index: includes/scripts/initialize-videos.html
===================================================================
new file mode 100644
--- /dev/null
+++ b/includes/scripts/initialize-videos.html
@@ -0,0 +1,7 @@
+<script>
+  document.addEventListener("DOMContentLoaded", function(event)

[ire, 2018/02/21 09:11:29]

Why have this in a separate file? We can check for the existence of
`.video-parent` elements in the videos.js file instead of the extra step of
having to include this script.

[juliandoucette, 2018/02/21 10:35:18]

I prefer to define a class/module in one file and apply it in another because
one may want to import said class/module and not apply it immediately/globally.
I chose to write a" Video class/function/module" instead of an "initialize all
videos script" - if that makes sense.

[ire, 2018/02/22 09:25:41]

(Forgot to say that this is a NIT)

Is there ever a case in which we would have the `.video-parent` and
corresponding children and not want it initialised?

I agree with the decision to create the Video class, I just think there may not
be a need for having a separate/external script to intialise the Video when we
never want uninitialised videos. I guess my suggestion is to initialise the
videos in the main script instead of requiring a separate step of including the
script.

[juliandoucette, 2018/02/23 13:31:07]

I take your point. Thank you for explaining / pushing back. Done.

[ire, 2018/02/26 18:33:18]

You're welcome :)

+  {
+    window.videos = [].slice.call(document.querySelectorAll(".video-parent"))
+      .map(function(parent) {return new Video(parent);});
+  });
+</script>