Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 29704603: Issue 5945 - Removed sudo suggestion from node module READMEs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by juliandoucette
Modified:
1 year, 11 months ago
Reviewers:
Sebastian Noack, tlucas
Base URL:
https://hg.adblockplus.org/codingtools
Visibility:
Public.

Description

Issue 5945 - Removed sudo suggestion from node module READMEs

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M eslint-config-eyeo/README.md View 1 chunk +0 lines, -2 lines 0 comments Download
M stylelint-config-eyeo/README.md View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
2 years ago (2018-02-21 16:36:02 UTC) #1
juliandoucette
I chose to remove the suggestion entirely instead of mentioning that the command requires permission ...
2 years ago (2018-02-21 16:38:16 UTC) #2
tlucas
LGTM
1 year, 11 months ago (2018-03-07 12:41:23 UTC) #3
Sebastian Noack
LGTM
1 year, 11 months ago (2018-03-07 16:43:26 UTC) #4
juliandoucette
1 year, 11 months ago (2018-03-09 14:31:44 UTC) #5

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5