Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29704603: Issue 5945 - Removed sudo suggestion from node module READMEs (Closed)

Created:
Feb. 21, 2018, 4:36 p.m. by juliandoucette
Modified:
March 9, 2018, 2:31 p.m.
Reviewers:
Sebastian Noack, tlucas
Base URL:
https://hg.adblockplus.org/codingtools
Visibility:
Public.

Description

Issue 5945 - Removed sudo suggestion from node module READMEs

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M eslint-config-eyeo/README.md View 1 chunk +0 lines, -2 lines 0 comments Download
M stylelint-config-eyeo/README.md View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
Feb. 21, 2018, 4:36 p.m. (2018-02-21 16:36:02 UTC) #1
juliandoucette
I chose to remove the suggestion entirely instead of mentioning that the command requires permission ...
Feb. 21, 2018, 4:38 p.m. (2018-02-21 16:38:16 UTC) #2
tlucas
LGTM
March 7, 2018, 12:41 p.m. (2018-03-07 12:41:23 UTC) #3
Sebastian Noack
LGTM
March 7, 2018, 4:43 p.m. (2018-03-07 16:43:26 UTC) #4
juliandoucette
March 9, 2018, 2:31 p.m. (2018-03-09 14:31:44 UTC) #5

Powered by Google App Engine
This is Rietveld