Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: package.json

Issue 29705690: Issue 6310 - Start using JavaScript modularization tool (Closed)
Patch Set: Created Feb. 22, 2018, 5:22 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« .hgignore ('K') | « js/desktop-options.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: package.json
===================================================================
--- a/package.json
+++ b/package.json
@@ -1,16 +1,23 @@
{
"name": "adblockplusui",
"private": true,
"description": "Adblock Plus UI",
"scripts": {
"lint": "npm run lint:js",
"lint:js": "eslint ./*.js ./lib/*.js ./ext/*.js",
"prepare": "python2 ensure_dependencies.py",
- "start": "http-server"
+ "start": "http-server",
saroyanm 2018/02/22 19:07:28 Suggestion: What about watching changes while runn
a.giammarchi 2018/02/23 08:51:37 IIRC you can have only one output in console throu
saroyanm 2018/02/23 11:26:16 I agree that build is more important, I have coupl
a.giammarchi 2018/02/23 12:02:10 current command works just fine and we don't need
+ "bundle": "npm run bundle:desktop-options",
saroyanm 2018/02/22 19:07:28 Detail: I think it will be helpful to document in
a.giammarchi 2018/02/23 08:51:37 it's a matter of copy and paste using a different
+ "bundle:desktop-options": "eslint ./js/**/*.js && echo '/* eslint-disable */// BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js",
saroyanm 2018/02/22 18:54:32 What does double ">>" mean in browserify, I though
a.giammarchi 2018/02/23 08:51:37 as explained by email, > and >> are not browserify
saroyanm 2018/02/23 11:26:16 Acknowledged.
+ "watch": "npm run watch:desktop-options",
+ "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",
+ "postinstall": "npm run bundle"
},
"devDependencies": {
+ "browserify": "^16.1.0",
"eslint": "^4.16.0",
"eslint-config-eyeo": "^2.0.0",
- "http-server": "^0.11.1"
+ "http-server": "^0.11.1",
+ "watch": "^1.0.2"
}
}
« .hgignore ('K') | « js/desktop-options.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld