Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29709593: Noissue - Lower opacity of media images on hover on abp.org homepage (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: HighPDI icon and solid black background color Created Feb. 26, 2018, 6:45 p.m.
Right Patch Set: Addressed NITs Created Feb. 28, 2018, 8:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/index.tmpl ('k') | static/css/index-desktop.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content 1 #content
2 { 2 {
3 padding-top: 5em; 3 padding-top: 5em;
4 margin: 0 auto; 4 margin: 0 auto;
5 } 5 }
6 6
7 #key-facts h1 7 #key-facts h1
8 { 8 {
9 font-size: 16px; 9 font-size: 16px;
10 } 10 }
(...skipping 717 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 } 728 }
729 729
730 #media-list a 730 #media-list a
731 { 731 {
732 position: relative; 732 position: relative;
733 display: block; 733 display: block;
734 } 734 }
735 735
736 #media-list a:hover img 736 #media-list a:hover img
737 { 737 {
738 opacity: 0.2; 738 opacity: 0.3;
739 } 739 }
740 740
741 #media-list a:hover:after 741 #media-list a:hover:after
742 { 742 {
743 content: ""; 743 content: "";
744 position: absolute; 744 position: absolute;
745 top: 50%; 745 top: 50%;
746 left: 50%; 746 left: 50%;
747 height: 1em; 747 height: 1em;
748 width: 1em; 748 width: 1em;
749 padding: 1em; 749 padding: 1em;
juliandoucette 2018/02/27 12:57:04 NIT/Suggest: I think round edges would be nicer th
ire 2018/02/28 08:45:18 Done.
750 margin-left: -1em; 750 margin-left: -1em;
751 margin-top: -1em; 751 margin-top: -1em;
752 border-radius: 50%;
752 background-color: #000; 753 background-color: #000;
753 background-image: url(../img/external-icon.png); 754 background-image: url(../img/external-icon.png);
754 background-image: linear-gradient(transparent, transparent), 755 background-image: linear-gradient(transparent, transparent),
755 url(../img/external-icon.svg); 756 url(../img/external-icon.svg);
ire 2018/02/26 18:46:08 The SVG image wasn't being served previously, I us
juliandoucette 2018/02/27 12:57:04 Acknowledged.
756 background-repeat: no-repeat; 757 background-repeat: no-repeat;
757 background-position: center; 758 background-position: center;
758 background-size: 1em; 759 background-size: 1em;
759 } 760 }
760 761
761 @media (min-width: 768px) 762 @media (min-width: 768px)
762 { 763 {
763 #media-header small 764 #media-header small
764 { 765 {
765 display: none; 766 display: none;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 { 811 {
811 #media-list 812 #media-list
812 { 813 {
813 display: flex; 814 display: flex;
814 justify-content: space-between; 815 justify-content: space-between;
815 align-items: center; 816 align-items: center;
816 } 817 }
817 } 818 }
818 819
819 } 820 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld