Noissue - Lower opacity of media images on hover on abp.org homepage

Noissue - Lower opacity of media images on hover on abp.org homepage

[juliandoucette, 2018-02-26 13:10:22]

Still looks blurry to me. This is probably not helped by the fact that the icon
is not highDPI. I suggest:

1. Less opacity to the logo behind (30%?)
2. Solid black background on the icon (and a couple pixels around?)
3. HighPDI icon

[ire, 2018-02-26 18:46:08]

On 2018/02/26 13:10:22, juliandoucette wrote:
> Still looks blurry to me. This is probably not helped by the fact that the
icon
> is not highDPI. I suggest:
> 
> 1. Less opacity to the logo behind (30%?)

The opacity is already at 20%

> 2. Solid black background on the icon (and a couple pixels around?)

Done 

> 3. HighPDI icon

Done

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.css
File static/css/index.css (right):

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.cs...
static/css/index.css:755: url(../img/external-icon.svg);
The SVG image wasn't being served previously, I used the wrong way to serve it

[juliandoucette, 2018-02-27 12:57:05]

LGTM + NITs

> The opacity is already at 20%

I know. I meant that the opacity can be higher (the logo can be more visible) if
the external link icon has a solid black background behind it. Please use your
best judgement.

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.css
File static/css/index.css (right):

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.cs...
static/css/index.css:749: padding: 1em;
NIT/Suggest: I think round edges would be nicer than sharp edges. This could be
accomplished via border-radius.

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.cs...
static/css/index.css:755: url(../img/external-icon.svg);
On 2018/02/26 18:46:08, ire wrote:
> The SVG image wasn't being served previously, I used the wrong way to serve it

Acknowledged.

[ire, 2018-02-28 08:45:18]

Thanks Julian!

On 2018/02/27 12:57:05, juliandoucette wrote:
> I know. I meant that the opacity can be higher (the logo can be more visible)
if
> the external link icon has a solid black background behind it. Please use your
> best judgement.

Done

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.css
File static/css/index.css (right):

https://codereview.adblockplus.org/29709593/diff/29709623/static/css/index.cs...
static/css/index.css:749: padding: 1em;
On 2018/02/27 12:57:04, juliandoucette wrote:
> NIT/Suggest: I think round edges would be nicer than sharp edges. This could
be
> accomplished via border-radius.

Done.