Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29710595: Issue 6433 - Use generators in getURLsFromElement (Closed)

Created:
Feb. 28, 2018, 12:54 a.m. by Manish Jethani
Modified:
March 18, 2019, 5:15 a.m.
Reviewers:
CC:
kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Extract localName #

Patch Set 3 : Use functional style #

Patch Set 4 : Minor changes #

Patch Set 5 : Refactor (fixed) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -72 lines) Patch
M include.preload.js View 1 2 3 4 1 chunk +48 lines, -72 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
Feb. 28, 2018, 12:54 a.m. (2018-02-28 00:54:27 UTC) #1
Manish Jethani
Patch Set 1 No reason to do this other than to make the code a ...
Feb. 28, 2018, 1:01 a.m. (2018-02-28 01:01:23 UTC) #2
Manish Jethani
Patch Set 3 Now I am just pushing my luck with Patch Set 3 though ...
Feb. 28, 2018, 9:44 a.m. (2018-02-28 09:44:19 UTC) #3
kzar
Please can you file an issue about using generators in general, make it blocking #6425 ...
Feb. 28, 2018, 11:16 a.m. (2018-02-28 11:16:20 UTC) #4
Manish Jethani
On 2018/02/28 11:16:20, kzar wrote: > Please can you file an issue about using generators ...
Feb. 28, 2018, 8:26 p.m. (2018-02-28 20:26:41 UTC) #5
Manish Jethani
Patch Set 4: Minor changes
Feb. 28, 2018, 8:59 p.m. (2018-02-28 20:59:22 UTC) #6
Manish Jethani
Feb. 28, 2018, 10:54 p.m. (2018-02-28 22:54:00 UTC) #7
Patch Set 5: Refactor

Powered by Google App Engine
This is Rietveld