Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29711681: Noissue - Remove Redundant Parentheses (Closed)

Created:
Feb. 28, 2018, 11:49 p.m. by Jon Sonesen
Modified:
March 6, 2018, 12:31 a.m.
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/cms
Visibility:
Public.

Description

Noissue - Remove Redundant Parentheses

Patch Set 1 : #

Total comments: 1

Patch Set 2 : add list comprehension and positional args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cms/converters.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Jon Sonesen
Feb. 28, 2018, 11:49 p.m. (2018-02-28 23:49:12 UTC) #1
Jon Sonesen
https://codereview.adblockplus.org/29711681/diff/29711684/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29711681/diff/29711684/cms/converters.py#newcode184 cms/converters.py:184: def stringify_attribute(attribute): alternatively, you can expand tuples when passed ...
March 1, 2018, midnight (2018-03-01 00:00:15 UTC) #2
Vasily Kuznetsov
March 5, 2018, 10:35 a.m. (2018-03-05 10:35:11 UTC) #3
Patch 2 LGTM!

Powered by Google App Engine
This is Rietveld