Noissue - Update docs to describe include files metadata override

Noissue - Update docs to describe include files metadata override

[Jon Sonesen, 2018-03-01 01:53:51]

Just figured, since the comment in converters.py points this out. This is
something that should be mentioned. What do you think?

[Vasily Kuznetsov, 2018-03-01 15:41:21]

He Jon,

Good idea to document this behavior (even though it's still to be decided if it
is desirable).

However, "override" sounds a bit like all page metadata might be replaced with
the include metadata. What do you think about my proposed way to formulate it?

Cheers,
Vasily

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
File docs/content/includes.md (right):

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
docs/content/includes.md:12: Also, page front matter (metadata defined at the
top of the file) will
Maybe better to formulate this as something like "the metadata variables from
the include file will be added to the page metadata (with the metadata variables
from the include having priority)"? What do you think?

[Jon Sonesen, 2018-03-02 00:58:01]

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
File docs/content/includes.md (right):

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
docs/content/includes.md:12: Also, page front matter (metadata defined at the
top of the file) will
On 2018/03/01 15:41:21, Vasily Kuznetsov wrote:
> Maybe better to formulate this as something like "the metadata variables from
> the include file will be added to the page metadata (with the metadata
variables
> from the include having priority)"? What do you think?

Yeah thats much better, thanks. This means that an include can change the
template of a page correct? if so perhaps this should also be pointed out.

[Jon Sonesen, 2018-03-02 01:10:14]

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
File docs/content/includes.md (right):

https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
docs/content/includes.md:12: Also, page front matter (metadata defined at the
top of the file) will
On 2018/03/01 15:41:21, Vasily Kuznetsov wrote:
> Maybe better to formulate this as something like "the metadata variables from
> the include file will be added to the page metadata (with the metadata
variables
> from the include having priority)"? What do you think?

basically add to yours, "this means that a include file is capable of things
like overriding a page's default template."?

[Vasily Kuznetsov, 2018-03-02 13:31:42]

On 2018/03/02 01:10:14, Jon Sonesen wrote:
>
https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
> File docs/content/includes.md (right):
> 
>
https://codereview.adblockplus.org/29711686/diff/29711687/docs/content/includ...
> docs/content/includes.md:12: Also, page front matter (metadata defined at the
> top of the file) will
> On 2018/03/01 15:41:21, Vasily Kuznetsov wrote:
> > Maybe better to formulate this as something like "the metadata variables
from
> > the include file will be added to the page metadata (with the metadata
> variables
> > from the include having priority)"? What do you think?
> 
> basically add to yours, "this means that a include file is capable of things
> like overriding a page's default template."?

This sounds good but it seems the change didn't make it to P2 upload, it seems
the same as P1.

[Jon Sonesen, 2018-03-08 20:49:31]

Fixed

[Vasily Kuznetsov, 2018-03-09 10:21:16]

On 2018/03/08 20:49:31, Jon Sonesen wrote:
> Fixed

Patch set 3 LGTM!