Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29713591: Noissue - add `addRef = true` argument to `intrusive_ptr::reset` (Closed)

Created:
March 2, 2018, 3:40 p.m. by sergei
Modified:
March 6, 2018, 4:21 p.m.
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

Now it has the same functionality as the constructor. Review: https://codereview.adblockplus.org/29713591 # Extracted from https://codereview.adblockplus.org/29548581/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M compiled/intrusive_ptr.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
March 2, 2018, 3:44 p.m. (2018-03-02 15:44:28 UTC) #1
hub
March 2, 2018, 5:03 p.m. (2018-03-02 17:03:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld