Issue 29713594: #Too long, see below

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29713594: #Too long, see below (Closed)

Created:
March 2, 2018, 3:40 p.m. by sergei

Modified:
March 6, 2018, 4:21 p.m.

Reviewers:
René Jeschke, hub, Oleksandr

Base URL:
github.com:adblockplus/adblockpluscore

Visibility:
Public.

Description

Noissue - move the check whether a template parameter of `intrusive_ptr` inherits `ref_counted` in `static_assert`. It is in the class definition and it allows to use it with yet incomplete class, e.g. `class Subscription; typedef intrusive_ptr<Subscription> SubscriptionPtr;`. Review: https://codereview.adblockplus.org/29713594 # Extracted from https://codereview.adblockplus.org/29548581/