Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29714558: Noissue - use static_assert for SFINAE for better error messaging (Closed)

Created:
March 5, 2018, 11:39 a.m. by sergei
Modified:
March 6, 2018, 4:27 p.m.
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29714558 # It origins from https://codereview.adblockplus.org/29713594/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M compiled/StringMap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/bindings/generator.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
March 5, 2018, 11:47 a.m. (2018-03-05 11:47:34 UTC) #1
hub
March 5, 2018, 2:21 p.m. (2018-03-05 14:21:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld