Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 29714583: Issue 6220 - include running of native tests on travis-ci for emscripten (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by sergei
Modified:
1 year, 11 months ago
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

We are implementing some fundamental functionality and it's tested in native tests, so it makes a lot of sense to run those tests automatically.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M .travis/travis-script.sh View 1 chunk +10 lines, -2 lines 2 comments Download

Messages

Total messages: 4
sergei
1 year, 11 months ago (2018-03-05 15:31:16 UTC) #1
hub
https://codereview.adblockplus.org/29714583/diff/29714584/.travis/travis-script.sh File .travis/travis-script.sh (right): https://codereview.adblockplus.org/29714583/diff/29714584/.travis/travis-script.sh#newcode20 .travis/travis-script.sh:20: ./build/native/abptest `ninja -C build/native test` is enough to build ...
1 year, 11 months ago (2018-03-05 15:35:24 UTC) #2
sergei
https://codereview.adblockplus.org/29714583/diff/29714584/.travis/travis-script.sh File .travis/travis-script.sh (right): https://codereview.adblockplus.org/29714583/diff/29714584/.travis/travis-script.sh#newcode20 .travis/travis-script.sh:20: ./build/native/abptest On 2018/03/05 15:35:24, hub wrote: > `ninja -C ...
1 year, 11 months ago (2018-03-05 15:58:16 UTC) #3
hub
1 year, 11 months ago (2018-03-05 16:28:46 UTC) #4
fair enough

(you could also `cat build/native/meson-logs/testlog.txt` but that's not much
better)

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5