Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 29714606: Issue 6505 - Make selector parameter in makeSelector optional (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by Manish Jethani
Modified:
1 year, 11 months ago
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year, 11 months ago (2018-03-05 19:57:38 UTC) #1
Manish Jethani
Patch Set 1
1 year, 11 months ago (2018-03-05 19:58:41 UTC) #2
Manish Jethani
Dave, I'm moving you to CC in all these types of reviews, but this one ...
1 year, 11 months ago (2018-03-07 16:06:38 UTC) #3
kzar
LGTM, but since the issue is for Platform (adblockpluschrome) you need a separate issue for ...
1 year, 11 months ago (2018-03-19 20:19:13 UTC) #4
Manish Jethani
1 year, 11 months ago (2018-03-20 11:44:56 UTC) #5
On 2018/03/19 20:19:13, kzar wrote:
> LGTM, but since the issue is for Platform (adblockpluschrome) you need a
> separate issue for adblockpluscore changes.

Done.

https://issues.adblockplus.org/ticket/6505

I'll go ahead and land this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5