Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29714606: Issue 6505 - Make selector parameter in makeSelector optional (Closed)

Created:
March 5, 2018, 7:57 p.m. by Manish Jethani
Modified:
March 20, 2018, 11:50 a.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
March 5, 2018, 7:57 p.m. (2018-03-05 19:57:38 UTC) #1
Manish Jethani
Patch Set 1
March 5, 2018, 7:58 p.m. (2018-03-05 19:58:41 UTC) #2
Manish Jethani
Dave, I'm moving you to CC in all these types of reviews, but this one ...
March 7, 2018, 4:06 p.m. (2018-03-07 16:06:38 UTC) #3
kzar
LGTM, but since the issue is for Platform (adblockpluschrome) you need a separate issue for ...
March 19, 2018, 8:19 p.m. (2018-03-19 20:19:13 UTC) #4
Manish Jethani
March 20, 2018, 11:44 a.m. (2018-03-20 11:44:56 UTC) #5
On 2018/03/19 20:19:13, kzar wrote:
> LGTM, but since the issue is for Platform (adblockpluschrome) you need a
> separate issue for adblockpluscore changes.

Done.

https://issues.adblockplus.org/ticket/6505

I'll go ahead and land this.

Powered by Google App Engine
This is Rietveld