Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29714613: Issue 6434 - Reimplement positionInParent with indexOf (Closed)

Created:
March 5, 2018, 8:25 p.m. by Manish Jethani
Modified:
March 20, 2018, 1:48 p.m.
Reviewers:
kzar
CC:
sergei, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Switch to indexOf #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Move findIndex up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M lib/content/elemHideEmulation.js View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M lib/coreUtils.js View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
March 5, 2018, 8:25 p.m. (2018-03-05 20:25:31 UTC) #1
Manish Jethani
Patch Set 1 (I'm not really pushing for this change, it's just an example.)
March 5, 2018, 8:30 p.m. (2018-03-05 20:30:54 UTC) #2
Manish Jethani
Patch Set 2: Switch to indexOf
March 5, 2018, 9:03 p.m. (2018-03-05 21:03:06 UTC) #3
kzar
LGTM https://codereview.adblockplus.org/29714613/diff/29714623/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29714613/diff/29714623/lib/coreUtils.js#newcode44 lib/coreUtils.js:44: function findIndex(iterable, callback, thisArg) Nit: Could you put ...
March 19, 2018, 8:53 p.m. (2018-03-19 20:53:22 UTC) #4
Manish Jethani
Patch Set 3: Rebase Patch Set 4: Move findIndex up https://codereview.adblockplus.org/29714613/diff/29714623/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29714613/diff/29714623/lib/coreUtils.js#newcode44 ...
March 20, 2018, 11:34 a.m. (2018-03-20 11:34:58 UTC) #5
kzar
March 20, 2018, 1:42 p.m. (2018-03-20 13:42:01 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld