Issue 29715555: Issue 6447 - Switch to Harmony modules in lib/*

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29715555: Issue 6447 - Switch to Harmony modules in lib/* (Closed)

Created:
March 6, 2018, 7:42 a.m. by Manish Jethani

Modified:
June 12, 2018, 8:49 a.m.

Reviewers:

CC:
kzar, sergei

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: March 6, 2018, 7:42 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -129 lines)			Patch
M	.eslintrc.json	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	lib/common.js	View	3 chunks	+3 lines, -9 lines	1 comment	Download
M	lib/content/elemHideEmulation.js	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	lib/coreUtils.js	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	lib/downloader.js	View	2 chunks	+11 lines, -10 lines	0 comments	Download
M	lib/elemHide.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/elemHideEmulation.js	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/events.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/filterClasses.js	View	9 chunks	+16 lines, -27 lines	0 comments	Download
M	lib/filterListener.js	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	lib/filterNotifier.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/filterStorage.js	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	lib/matcher.js	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	lib/notification.js	View	2 chunks	+8 lines, -9 lines	0 comments	Download
M	lib/rsa.js	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/subscriptionClasses.js	View	5 chunks	+9 lines, -14 lines	0 comments	Download
M	lib/synchronizer.js	View	1 chunk	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 https://codereview.adblockplus.org/29715555/diff/29715556/.eslintrc.json File .eslintrc.json (right): https://codereview.adblockplus.org/29715555/diff/29715556/.eslintrc.json#newcode5 .eslintrc.json:5: "sourceType": "module" We have to do ...

March 6, 2018, 7:44 a.m. (2018-03-06 07:44:53 UTC) #2

sergei

JIC, please do NOT land it before one finds out how to deal with it ...

March 6, 2018, 8:04 a.m. (2018-03-06 08:04:30 UTC) #3

Manish Jethani

March 6, 2018, 8:24 a.m. (2018-03-06 08:24:20 UTC) #4

On 2018/03/06 08:04:30, sergei wrote:
> JIC, please do NOT land it before one finds out how to deal with it in
> libadblockplus.

I will not land this.

Let's discuss on Trac.

Expand All Messages | Collapse All Messages