compiled/subscription/Subscription.cpp - Issue 29715695: Noissue - get rid of compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/subscription/Subscription.cpp

Issue 29715695: Noissue - get rid of compiler warnings (Closed) Base URL: github.com:adblockplus/adblockpluscore

Patch Set: Created March 6, 2018, 12:26 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: compiled/subscription/Subscription.cpp

diff --git a/compiled/subscription/Subscription.cpp b/compiled/subscription/Subscription.cpp

index 51211e9cb2d915c8e671d4c2765ac753965cea94..0f9387f2f3079f160dd401d3fcb2b3e063a227cb 100644

--- a/compiled/subscription/Subscription.cpp

+++ b/compiled/subscription/Subscription.cpp

@@ -101,7 +101,7 @@ Subscription* Subscription::FromID(const String& id)

{

int number = gen();

- for (int i = randomID.length() - 6; i < randomID.length(); i++)

+ for (String::size_type i = randomID.length() - 6; i < randomID.length(); i++)

{

randomID[i] = '0' + (number % 10);

number /= 10;

« no previous file with comments | « compiled/library.cpp ('k') | test/compiled/RegExp.cpp » ('j') | no next file with comments »