Issue 29715695: Noissue - get rid of compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29715695: Noissue - get rid of compiler warnings (Closed)

Created:
March 6, 2018, 12:26 p.m. by sergei

Modified:
March 6, 2018, 4:26 p.m.

Reviewers:
René Jeschke, Oleksandr, hub

Base URL:
github.com:adblockplus/adblockpluscore

Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29715695 # The reviewing tool broke again on the changeset, so please use patch view instead of comparison.

Patch Set 1 #

Created: March 6, 2018, 12:26 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -43 lines)			Patch
M	compiled/FilterNotifier.h	View	3 chunks	+39 lines, -22 lines	0 comments	Download
	compiled/bindings/main.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	compiled/debug.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
	compiled/filter/RegExpFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	compiled/library.h	View	3 chunks	+6 lines, -3 lines	0 comments	Download
	compiled/library.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
	compiled/subscription/Subscription.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	test/compiled/RegExp.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	test/compiled/StringMap.cpp	View	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages